Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End OIDC sessions upstream on signout #993

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

jraddaoui
Copy link
Collaborator

  • Follow signout redirect/callback flow to end sessions upstream.
  • Change environment configuration to set a base URL and generate the signin and signout redirect URLs from it.

Refs #957.

@jraddaoui jraddaoui requested review from djjuhasz and sbreker July 12, 2024 14:15
@jraddaoui jraddaoui self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.06%. Comparing base (27b772a) to head (6edaed7).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   53.13%   53.06%   -0.08%     
==========================================
  Files         101      101              
  Lines        5661     5661              
==========================================
- Hits         3008     3004       -4     
- Misses       2406     2408       +2     
- Partials      247      249       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jraddaoui jraddaoui force-pushed the dev/issue-957-signout branch 2 times, most recently from 3a5fe1e to cd402f5 Compare July 12, 2024 14:35
- Follow signout redirect/callback flow to end sessions upstream.
- Change environment configuration to set a base URL and generate
  the signin and signout redirect URLs from it.
@jraddaoui jraddaoui force-pushed the dev/issue-957-signout branch from cd402f5 to 6edaed7 Compare July 12, 2024 14:56
@jraddaoui jraddaoui merged commit 6edaed7 into main Jul 15, 2024
15 checks passed
@jraddaoui jraddaoui deleted the dev/issue-957-signout branch July 15, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant