-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access control checks to dashboard #978
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
=======================================
Coverage 53.10% 53.10%
=======================================
Files 101 101
Lines 5661 5661
=======================================
Hits 3006 3006
Misses 2407 2407
Partials 248 248 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jraddaoui 👍
61c66b1
to
26d62c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jraddaoui. Just a few comments.
- Add home page. - Split layout store: - Move user related elements to its own `auth` store. - Allow to disable OIDC authentication: - Consider a new environment variable to disable OIDC authentication. - Move configuration and user manager to auth store. - Remove user menu from sidebar and user name from home page when authentication is disabled. - Redirect to home page when visiting user signin pages with authentication disabled. - Add access control checks: - Consider new environment variables to enable Attribute Based Access Control and get a set of user attributes from a configurable claim in the access token. - Add attributes to auth store state and include actions to parse and check those attributes. - Configure protected routes and check attributes before each route change, redirecting to the home if the check fails. - Modify or hide elements (links, tabs, etc.) based on user attributes. - Change Keycloak's realm name to "artefactual".
26d62c0
to
f3e0f70
Compare
Thanks @djjuhasz! |
auth
store.authentication is disabled.
authentication disabled.
Control and get a set of user attributes from a configurable claim in
the access token.
check those attributes.
change, redirecting to the home if the check fails.
Refs #957.