Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save preprocesing tasks to Enduro DB #964

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Save preprocesing tasks to Enduro DB #964

merged 1 commit into from
Jun 18, 2024

Conversation

djjuhasz
Copy link
Collaborator

Fixes #949.

  • Add a local SavePreprocessingTask activity
  • Save tasks returned by the preprocessing child workflow to the Enduro DB as PreservationTasks so they are visible in the Dashboard UI

@djjuhasz djjuhasz force-pushed the dev/issues-949-save-preprocessing-tasks branch from 466b0a0 to 3c2198f Compare June 14, 2024 23:31
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.68817% with 44 lines in your changes missing coverage. Please review.

Project coverage is 51.30%. Comparing base (9307884) to head (90a19a9).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
internal/enums/preprocessing_task_outcome_enum.go 0.00% 31 Missing ⚠️
internal/workflow/processing.go 71.42% 7 Missing and 1 partial ⚠️
...rnal/workflow/localact/save_preprocessing_tasks.go 87.87% 2 Missing and 2 partials ⚠️
cmd/enduro/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
- Coverage   51.34%   51.30%   -0.05%     
==========================================
  Files         102      104       +2     
  Lines        5679     5768      +89     
==========================================
+ Hits         2916     2959      +43     
- Misses       2520     2562      +42     
- Partials      243      247       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djjuhasz djjuhasz force-pushed the dev/issues-949-save-preprocessing-tasks branch 2 times, most recently from ed49170 to a03d68a Compare June 15, 2024 00:52
@djjuhasz djjuhasz requested a review from jraddaoui June 15, 2024 00:56
jraddaoui
jraddaoui requested changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @djjuhasz!

internal/ingest/preprocessing_task.go Outdated Show resolved Hide resolved
internal/preprocessing/preprocessing.go Outdated Show resolved Hide resolved
internal/workflow/localact/save_ingest_tasks.go Outdated Show resolved Hide resolved
internal/workflow/localact/save_ingest_tasks.go Outdated Show resolved Hide resolved
internal/workflow/processing.go Outdated Show resolved Hide resolved
@djjuhasz djjuhasz requested a review from jraddaoui June 17, 2024 20:55
jraddaoui
jraddaoui approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djjuhasz! One final thought, but looks great me.

internal/workflow/processing.go Outdated Show resolved Hide resolved
@djjuhasz
Save preprocesing tasks to Enduro DB
90a19a9 
Fixes #949.

- Add a local SavePreprocessingTask activity
- Save tasks returned by the preprocessing child workflow to the Enduro
  DB as PreservationTasks so they are visible in the Dashboard UI
- Add a make "gen-enums" target to generate enums with go-enums
- Add an enum for ingest task outcomes
@djjuhasz djjuhasz force-pushed the dev/issues-949-save-preprocessing-tasks branch from 09b42dc to 90a19a9 Compare June 18, 2024 16:12
@djjuhasz djjuhasz merged commit 9564b21 into main Jun 18, 2024
15 checks passed
@djjuhasz djjuhasz deleted the dev/issues-949-save-preprocessing-tasks branch June 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jraddaoui jraddaoui jraddaoui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: child workflow tasks aren't visible in the UI
2 participants
@djjuhasz @jraddaoui