Fix security schema in API design #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jraddaoui
force-pushed
the
dev/issue-957-goa-security
branch
from
c2fa3d3 to
3f32335
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 51.31% 51.34% +0.03%
==========================================
Files 102 102
Lines 5679 5679
==========================================
+ Hits 2914 2916 +2
+ Misses 2521 2520 -1
+ Partials 244 243 -1 ☔ View full report in Codecov by Sentry. |
Use Goa's JWTSecurity, the API is only verifying the token against the OIDC provider, it's not actually doing the authentication flow.
jraddaoui
force-pushed
the
dev/issue-957-goa-security
branch
from
3f32335 to
9307884
Compare
djjuhasz
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Goa's JWTSecurity, the API is only verifying the token against the OIDC provider, it's not actually doing the authentication flow.
Refs #957.