Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove working dirs when worker session completes #946

Merged
merged 2 commits into from
May 30, 2024

Conversation

djjuhasz
Copy link
Collaborator

No description provided.

djjuhasz added 2 commits May 30, 2024 09:54
The upstream go-bagit `ValidateBag()` interface changed in the upgrade
from version 0.2.0-alpha and 0.3.0-alpha.
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 50.53%. Comparing base (c2b9680) to head (eff9df2).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
internal/workflow/processing.go 71.42% 5 Missing and 3 partials ⚠️
cmd/enduro-a3m-worker/main.go 0.00% 2 Missing ⚠️
cmd/enduro-am-worker/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
+ Coverage   50.45%   50.53%   +0.07%     
==========================================
  Files         102      101       -1     
  Lines        5621     5638      +17     
==========================================
+ Hits         2836     2849      +13     
+ Misses       2546     2545       -1     
- Partials      239      244       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djjuhasz djjuhasz requested a review from jraddaoui May 30, 2024 17:11
Copy link
Collaborator

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @djjuhasz!

@djjuhasz djjuhasz merged commit 6106009 into main May 30, 2024
15 checks passed
@djjuhasz djjuhasz deleted the dev/clean-up-working-dirs branch May 30, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants