Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a3m shareDir config value in processing #865

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

djjuhasz
Copy link
Collaborator

@djjuhasz djjuhasz commented Feb 21, 2024

Refs #864

  • Pass the full enduro config to processing workflow, and remove the separate taskQueue parameter
  • Use config value for A3m shareDir in processing.go
  • Use a temporary directory as a shareDir in processing_test.go

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.00%. Comparing base (b0e5362) to head (6f286a7).
Report is 2 commits behind head on main.

Files Patch % Lines
main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
+ Coverage   45.33%   46.00%   +0.66%     
==========================================
  Files          93       94       +1     
  Lines        5036     5065      +29     
==========================================
+ Hits         2283     2330      +47     
+ Misses       2551     2533      -18     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djjuhasz djjuhasz force-pushed the dev/issue-864-fix-sharedir-config branch from dc21ed3 to eca89b6 Compare February 21, 2024 22:17
@djjuhasz
Copy link
Collaborator Author

djjuhasz commented Feb 21, 2024

Commit eca89b6 fixes a hardcoded a3m shared directory path in Enduro, but the processing workflow is still failing if the path is changed from the default. A3m finds the deposited SIP in the new path, and succesfully creates and AIP, but a3m is still saving the final AIP to the default "/home/a3m/.local/share/a3m/share/" directory instead of the new path. A3m doesn't pass the stored AIP path back to Enduro directly so Enduro is assuming the path of the AIP is "/home/a3m/.local/share/a3m/new_share/completed", which is not correct.

Fixing this completely will require changes to a3m.

Copy link
Contributor

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

internal/workflow/processing_test.go Outdated Show resolved Hide resolved
internal/workflow/processing.go Show resolved Hide resolved
Refs #864

- Pass the full enduro config to processing workflow, and remove the
  separate taskQueue parameter
- Use config value for A3m shareDir in processing.go
- Use a temporary directory as a shareDir in processing_test.go
@djjuhasz djjuhasz force-pushed the dev/issue-864-fix-sharedir-config branch from eca89b6 to 6f286a7 Compare February 29, 2024 17:15
@djjuhasz djjuhasz merged commit 1ff97e0 into main Feb 29, 2024
13 checks passed
@djjuhasz djjuhasz deleted the dev/issue-864-fix-sharedir-config branch February 29, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants