Fix sftp delete implementation #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
commented
Nov 21, 2023
sevein
commented
Nov 21, 2023
sevein
commented
Nov 21, 2023
Diogenesoftoronto
suggested changes
Nov 21, 2023
Diogenesoftoronto
approved these changes
Nov 22, 2023
I've found that the tests were not running because they were not named following the convention: TestXXX. After the update, the tests did not pass. These changes were needed: - Accept path relative to RemoteDir in Delete method. - Add `restrictDir` param to simulate permission error. - Unwrap sftp.StatusError to include status code in error message. Our test does not trigger the return of os.ErrPermission.
sevein
force-pushed
the
dev/sftp-improvements
branch
from
5874104 to
f5d5db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow-up for #772.