Use HTTP clients with better defaults #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks great. It always makes sense to remove globals like this, and have better defaults. |
Diogenesoftoronto
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our existing HTTP clients are built the right way, i.e. we're creating new clients with
&http.Client{}and they have a timeout set, as opposed to relying onhttp.DefaultClientwhich is shared and mutable. But in this pull request I'm proposing to use clienthttp because in addition to promoting non-global clients they come with good defaults for a couple of different scenarios: DefaultClient (for short-lived conns against arbitrary hosts) and DefaultPooledClient (for connection reuse against same hosts).