Make task queues configurable

[Diogenesoftoronto]

refs #621

[sevein]

I've suggested a number of minor modifications. I realize there are quite a few and I hope it's not overwhelming.

[Diogenesoftoronto]

Hey, this is ready to review again. I added all of your suggestions.

[sevein]

There is a failing test:

--- FAIL: TestServiceMoveStatus (0.01s)
    --- FAIL: TestServiceMoveStatus/Returns_move_done_if_workflow_completed (0.00s)

[Diogenesoftoronto]

It works!

[sevein]

A few small suggestions/questions.

[sevein]

It'd be nice if you don't include unrelated changes to go.mod in your commit if they're not strictly related.

[sevein]

Just realized this is ready for another review, will do tomorrow! Sorry for the late response.

[Diogenesoftoronto]

Just realized this is ready for another review, will do tomorrow! Sorry for the late response.

Perfectly fine. Should have sent you a DM.

[sevein]

GitHub won't allow me to comment on the specific line, but the storage.Submit method (L117) was not updated to pass the task queue to the upload workflow request. I had to make this change:

-       _, err = InitStorageUploadWorkflow(ctx, s.tc, &StorageUploadWorkflowRequest{AIPID: aipID})
+       _, err = InitStorageUploadWorkflow(ctx, s.tc, &StorageUploadWorkflowRequest{
+               AIPID:     aipID,
+               TaskQueue: s.config.TaskQueue,
+       })

Other than that, 👍. I'll merge, thank you!

This link shows the changes I had to make but it's confusing because it also includes the rebase work I did in preparation for the merge: compare:0f3b/60ee. The relevant bits are in internal/storage/service.go and internal/storage/service_test.go in case you're interested.