Optimize Makefile with lazy evaluation of packages #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
+ Coverage 55.45% 55.48% +0.03%
==========================================
Files 103 103
Lines 6021 6021
==========================================
+ Hits 3339 3341 +2
+ Misses 2432 2431 -1
+ Partials 250 249 -1 ☔ View full report in Codecov by Sentry. |
This commit updates the declarations of `PACKAGES` and related variables in the Makefile to implement lazy loading, so the computation is deferred until they are actually needed. Running commands like `make help` should now be faster (~80ms compared to ~500ms).
jraddaoui
force-pushed
the
dev/make-lazy-loading
branch
from
f21aef1 to
7d5bfb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the declarations of
PACKAGESand related variables in the Makefile to implement lazy loading, so the computation is deferred until they are actually needed.Running commands like
make helpshould now be faster (~80ms compared to ~500ms).