Remove .go-version file #1040
Merged
Remove .go-version file #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the .go-version file, as the Go version is now explicitly defined in the go directive within the go.mod file. Reminder: Go 1.21 introduced toolchain management, i.e. your local go command can manually download and install the release indicated in the go.mod file. This is also leveraged by tools like vscode.
sevein
force-pushed
the
dev/go-version
branch
from
7f4c1ef to
98453a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
=======================================
Coverage 55.35% 55.35%
=======================================
Files 103 103
Lines 6021 6021
=======================================
Hits 3333 3333
Misses 2435 2435
Partials 253 253 ☔ View full report in Codecov by Sentry. |
jraddaoui
approved these changes
Oct 14, 2024
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: ${{ steps.go_version.outputs.go_version }} | ||
| go-version-file: go.mod |
| @@ -104,7 +104,7 @@ Keycloack: | |||
| | Dashboard | <http://localhost:8080> | `admin` | `admin123` | | |||
| | MinIO console | <http://localhost:7460> | `admin` | `admin123` | | |||
| | Temporal UI | <http://localhost:7440> | `admin` | `admin123` | | |||
| | Keycloack | <http://localhost:7470> | `keycloack` | `keycloack123` | | |||
| | Keycloak | <http://localhost:7470> | `keycloak` | `keycloak123` | | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the .go-version file, as the Go version is now explicitly
defined in the go directive within the go.mod file.
Reminder: Go 1.21 introduced toolchain management, i.e. your local go command
can manually download and install the release indicated in the go.mod file. This
is also leveraged by tools like vscode.