Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade entgo version 0.13.1 -> 0.14.1 #1024

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Upgrade entgo version 0.13.1 -> 0.14.1 #1024

merged 3 commits into from
Sep 20, 2024

Conversation

djjuhasz
Copy link
Collaborator

@djjuhasz djjuhasz commented Sep 19, 2024

  • Upgrade go version 1.22.6 -> 1.23.1 (required by entgo 0.14.1)
  • Upgrade entgo version 0.13.1 -> 0.14.1
  • Upgrade golangci-lint version 1.58.1 -> 1.61.0

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.07%. Comparing base (b15e1aa) to head (a2f0a24).
Report is 61 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   53.05%   53.07%   +0.01%     
==========================================
  Files         100      100              
  Lines        5807     5807              
==========================================
+ Hits         3081     3082       +1     
+ Misses       2476     2474       -2     
- Partials      250      251       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djjuhasz!

I had to upgrade golangci-lint to at least 1.60.1 to make it work with Go 1.23.x, and there seems to be some Go mod issues too.

- Upgrade golangci-lint to 1.61.0 for compatiblity with go v1.23.1
- Address gosec G115 integer overflow warnings
@djjuhasz djjuhasz force-pushed the dev/bump-entgo-0.14.1 branch from 5493344 to a2f0a24 Compare September 20, 2024 16:18
@djjuhasz djjuhasz requested a review from jraddaoui September 20, 2024 17:45
@djjuhasz djjuhasz merged commit 5c3c952 into main Sep 20, 2024
15 checks passed
@djjuhasz djjuhasz deleted the dev/bump-entgo-0.14.1 branch September 20, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants