Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dashboard deps #1022

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Bump dashboard deps #1022

merged 1 commit into from
Sep 12, 2024

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Sep 12, 2024

I've updated all pending dependencies used by the dashboard, excepting @types/node which we still want to mantain on v20.x because we haven't upgrade to Node.js 22 yet.

$ npm outdated
Package      Current   Wanted  Latest  Location                  Depended by
@types/node  20.16.5  20.16.5  22.5.4  node_modules/@types/node  dashboard

For the record, the process I follow looks as follows:

  1. Run npm run deps (mentioned here) which launches an interactive user interface listing available updates,
  2. Bump some dependencies (start with patch and minor updates),
  3. Build (npm run build) and test (npm run test); confirm it works - if changes are required in our codebase, I launch vitest with npx vitest dev to watch the code and run the tests automatically while I make the necessary updates. Often I need to read the release notes, look up breaking changes, etc.
  4. Repeat until no outstanding deps listed.
  5. If the linter complains, run npx prettier . --write to fix.

During the upgrade, I've had to dealt with the following issues:

  • sass 1.72.0 » 1.78.0
    Silenced a new build warning (via vite.config.ts) related to the use of mixed declarations in Bootstrap. I've seen that this is being addressed in Bootstrap v5.3.4 but it has not been released yet.
  • unplugin-vue-router 0.8.5 » 0.10.8
    Dealt with some minor and well documented backward-incompatible changes introduced by v0.9 and v0.10. Also, we haven't adopted data loaders yet (added in v0.8), which is an interesting feature we should probably explore.
  • @vueuse/core 10.7.0 » 11.0.3
    Updated UUID.test.ts to mock document.execCommand('copy') which is the fallback mechanism to interact with the clipboard (see useClipboard for more details). I couldn't figure out how to fake the navigator permission instead - added a TODO note.

Fixes #1021.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.07%. Comparing base (cea3fe7) to head (81b750c).
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   53.10%   53.07%   -0.04%     
==========================================
  Files         100      100              
  Lines        5807     5807              
==========================================
- Hits         3084     3082       -2     
- Misses       2473     2474       +1     
- Partials      250      251       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works for me. Thanks @sevein. 👍

image

@sevein sevein merged commit b15e1aa into main Sep 12, 2024
15 checks passed
@sevein sevein deleted the dev/deps branch September 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: The Dashboard is using outdated npm packages
2 participants