Move API upload endpoint to package service #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
- Coverage 53.13% 53.01% -0.12%
==========================================
Files 101 100 -1
Lines 5814 5768 -46
==========================================
- Hits 3089 3058 -31
+ Misses 2474 2461 -13
+ Partials 251 249 -2 ☔ View full report in Codecov by Sentry. |
jraddaoui
force-pushed
the
dev/issue-977-upload-endpoint
branch
2 times, most recently
from
8c8ef3e to
b2fe128
Compare
sevein
reviewed
Sep 3, 2024
There was a problem hiding this comment.
For the record, I'm now remembering that a missing piece for this upload method to become super useful is to return an identifier, e.g. the workflow identifier, so a client can pull processing state. I think that we had an issue describing this limitation, but I can't find it.
- Remove the upload service and package. - Set up and close the upload bucket in main. - Update configuration: - Make upload max size configurable. - Use `go.artefactual.dev/tools/bucket` config struct. [skip-codecov]
|
This endpoint only proxies the upload to a bucket, the workflow is then triggered like a normal MinIO deposit, if properly configured. |
jraddaoui
force-pushed
the
dev/issue-977-upload-endpoint
branch
from
b2fe128 to
a0d454d
Compare
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.artefactual.dev/tools/bucketconfig struct.Refs #977.