Always evaluate preprocessing workflow Outcome

artefactual-sdps · Jun 18, 2024 · 786453a · 786453a
1 parent 9564b21
commit 786453a
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/internal/workflow/processing.go b/internal/workflow/processing.go
@@ -946,18 +946,16 @@ func (w *ProcessingWorkflow) preprocessing(ctx temporalsdk_workflow.Context, tin
 		if err != nil {
 			return err
 		}
-
-		switch ppResult.Outcome {
-		case preprocessing.OutcomeSuccess:
-			return nil
-		case preprocessing.OutcomeSystemError:
-			return errors.New("preprocessing workflow: system error")
-		case preprocessing.OutcomeContentError:
-			return errors.New("preprocessing workflow: validation failed")
-		default:
-			return fmt.Errorf("preprocessing workflow: unknown outcome %d", ppResult.Outcome)
-		}
 	}
 
-	return nil
+	switch ppResult.Outcome {
+	case preprocessing.OutcomeSuccess:
+		return nil
+	case preprocessing.OutcomeSystemError:
+		return errors.New("preprocessing workflow: system error")
+	case preprocessing.OutcomeContentError:
+		return errors.New("preprocessing workflow: validation failed")
+	default:
+		return fmt.Errorf("preprocessing workflow: unknown outcome %d", ppResult.Outcome)
+	}
 }