Remove original after extraction and SIP creation

internal/sfa/activities/create_sip.go

@@ -3,7 +3,11 @@ package activities
 import (
 	"context"
 	"errors"
+	"fmt"
+	"os"
 	"os/exec"
+
+	"go.artefactual.dev/tools/temporal"
 )
 
 const SipCreationName = "sip-creation"
@@ -34,6 +38,10 @@ func (sc *SipCreationActivity) Execute(ctx context.Context, params *SipCreationP
 		return nil, errors.New("Failed to repackage sip correctly: " + res.Out)
 	}
 
+	if err = os.Remove(params.SipPath); err != nil {
+		return nil, temporal.NewNonRetryableError(fmt.Errorf("error removing SIP: %v", err))
+	}
+
 	res.NewSipPath = params.SipPath + "_bag"
 	return res, nil
 }

internal/sfa/activities/extract_package.go

@@ -64,5 +64,9 @@ func (a *ExtractPackage) Execute(ctx context.Context, params *ExtractPackagePara
 		path = filepath.Join(tempDir, entries[0].Name())
 	}
 
+	if err = os.Remove(params.Path); err != nil {
+		return nil, temporal.NewNonRetryableError(fmt.Errorf("error removing package file: %v", err))
+	}
+
 	return &ExtractPackageResult{Path: path}, nil
 }

internal/sfa/sfa.go

@@ -67,9 +67,6 @@ func ExecuteActivities(ctx temporalsdk_workflow.Context, path string, key string
 			return err
 		}
 
-		// TODO: w.cleanUpPath() no longer exists.
-		// w.cleanUpPath(extractPackageRes.Path)
-
 		// Validate SIP structure.
 		var checkStructureRes activities.CheckSipStructureResult
 		err = temporalsdk_workflow.ExecuteActivity(withLocalActOpts(ctx), activities.CheckSipStructureName, &activities.CheckSipStructureParams{
@@ -106,9 +103,6 @@ func ExecuteActivities(ctx temporalsdk_workflow.Context, path string, key string
 			return err
 		}
 
-		// TODO: w.cleanUpPath() no longer exists.
-		// w.cleanUpPath(sipCreation.NewSipPath)
-
 		// We do this so that the code above only stops when a non-bussines error is found.
 		if !allowedFileFormats.Ok {
 			return activities.ErrIlegalFileFormat

internal/workflow/processing.go

@@ -666,9 +666,6 @@ func (w *ProcessingWorkflow) transferAM(sessCtx temporalsdk_workflow.Context, ti
 		return err
 	}
 
-	// TODO: w.cleanUpPath() no longer exists.
-	// w.cleanUpPath(zipResult.Path) // Delete when workflow completes.
-
 	defer func() {
 		if err != nil {
 			err = errors.Join(err, sfa.SendToFailedSIPs(sessCtx, zipResult.Path, tinfo.req.Key))