Skip to content

Commit

Permalink
Upgrade log4j to 2.15.0
Browse files Browse the repository at this point in the history
Originally we tried to a log4j update in elastic#47298, but we were unable to
that due to the `DeprecationLoggerTests.testLogPermissions` test
failing. The test relied on mocking and got removed in
https://github.com/elastic/elasticsearch/pull/61474/files#diff-70de5a6ba5c637e7f19c51341417760d6e957beb5a1fa5703049095ea2719ee0L47

Now we should be able to the upgrade and then we can address the Security
Manager permission questions raised in elastic#47298 separately.
  • Loading branch information
pgomulka authored and arteam committed Dec 14, 2021
1 parent 5ce8b8c commit 1089bd8
Show file tree
Hide file tree
Showing 42 changed files with 41 additions and 25 deletions.
2 changes: 1 addition & 1 deletion build-tools-internal/version.properties
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ snakeyaml = 1.26
icu4j = 68.2
supercsv = 2.4.0
# when updating log4j, please update also docs/java-api/index.asciidoc
log4j = 2.11.1
log4j = 2.15.0
slf4j = 1.6.2
ecsLogging = 1.2.0

Expand Down
3 changes: 2 additions & 1 deletion modules/repository-url/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ tasks.named("thirdPartyAudit").configure {
'javax.servlet.ServletContextListener',
'org.apache.avalon.framework.logger.Logger',
'org.apache.log.Hierarchy',
'org.apache.log.Logger'
'org.apache.log.Logger',
'javax.jms.Message'
)
}

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bc960fe2acbe6f3952011f88a771de18301534e7
1 change: 1 addition & 0 deletions plugins/discovery-azure-classic/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.avalon.framework.logger.Logger',
'org.apache.log.Hierarchy',
'org.apache.log.Logger',
'javax.jms.Message',
'org.eclipse.persistence.descriptors.ClassDescriptor',
'org.eclipse.persistence.internal.oxm.MappingNodeValue',
'org.eclipse.persistence.internal.oxm.TreeObjectBuilder',
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bc960fe2acbe6f3952011f88a771de18301534e7
1 change: 1 addition & 0 deletions plugins/discovery-ec2/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.avalon.framework.logger.Logger',
'org.apache.log.Hierarchy',
'org.apache.log.Logger',
'javax.jms.Message',
'javax.xml.bind.DatatypeConverter',
'javax.xml.bind.JAXBContext'
)
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bc960fe2acbe6f3952011f88a771de18301534e7
6 changes: 6 additions & 0 deletions plugins/discovery-gce/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.avalon.framework.logger.Logger',
'org.apache.log.Hierarchy',
'org.apache.log.Logger',
'org.apache.avalon.framework.logger.Logger',
'com.google.common.collect.Lists',
'javax.jms.Message',
'org.apache.log.Logger',
'org.apache.log.Hierarchy',
'javax.servlet.ServletContextListener',
'org.apache.http.ConnectionReuseStrategy',
'org.apache.http.Header',
'org.apache.http.HttpEntity',
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bc960fe2acbe6f3952011f88a771de18301534e7
4 changes: 3 additions & 1 deletion plugins/repository-gcs/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.avalon.framework.logger.Logger',
'org.apache.log.Hierarchy',
'org.apache.log.Logger',
'javax.jms.Message',

// optional apache http client dependencies
'org.apache.http.ConnectionReuseStrategy',
'org.apache.http.Header',
Expand Down Expand Up @@ -180,7 +182,7 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.http.protocol.HttpRequestExecutor',
// commons-logging provided dependencies
'javax.servlet.ServletContextEvent',
'javax.servlet.ServletContextListener'
'javax.servlet.ServletContextListener',
)
}

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bc960fe2acbe6f3952011f88a771de18301534e7

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bc960fe2acbe6f3952011f88a771de18301534e7

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8bb417869ab3baa19f2fc70e6d776d041f0a8ebc
3 changes: 2 additions & 1 deletion plugins/repository-s3/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.avalon.framework.logger.Logger',
'org.apache.log.Hierarchy',
'org.apache.log.Logger',
'javax.jms.Message',
'software.amazon.ion.IonReader',
'software.amazon.ion.IonSystem',
'software.amazon.ion.IonType',
Expand All @@ -308,6 +309,6 @@ tasks.named("thirdPartyAudit").configure {
'com.amazonaws.services.kms.model.EncryptResult',
'com.amazonaws.services.kms.model.GenerateDataKeyRequest',
'com.amazonaws.services.kms.model.GenerateDataKeyResult',
'javax.activation.DataHandler'
'javax.activation.DataHandler',
)
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bc960fe2acbe6f3952011f88a771de18301534e7
2 changes: 0 additions & 2 deletions server/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,9 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.commons.compress.utils.IOUtils',
'org.apache.commons.csv.CSVFormat',
'org.apache.commons.csv.QuoteMode',
'org.apache.kafka.clients.producer.Callback',
'org.apache.kafka.clients.producer.Producer',
'org.apache.kafka.clients.producer.RecordMetadata',
'org.codehaus.stax2.XMLStreamWriter2',
'org.jctools.queues.MessagePassingQueue$Consumer',
'org.jctools.queues.MpscArrayQueue',
'org.osgi.framework.Bundle',
'org.osgi.framework.BundleActivator',
Expand Down
1 change: 0 additions & 1 deletion server/licenses/log4j-api-2.11.1.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions server/licenses/log4j-api-2.15.0.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
4a5aa7e55a29391c6f66e0b259d5189aa11e45d0
1 change: 0 additions & 1 deletion server/licenses/log4j-core-2.11.1.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions server/licenses/log4j-core-2.15.0.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ba55c13d7ac2fd44df9cc8074455719a33f375b9
10 changes: 9 additions & 1 deletion x-pack/plugin/core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,15 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.log.Logger',
//commons-logging provided dependencies
'javax.servlet.ServletContextEvent',
'javax.servlet.ServletContextListener'
'javax.servlet.ServletContextListener',

'org.apache.avalon.framework.logger.Logger',
'javax.jms.Message',
'org.apache.log.Logger',
'org.apache.log.Hierarchy',
'org.apache.log.Logger',
'javax.servlet.ServletContextListener',
'javax.servlet.ServletContextEvent'
)
}

Expand Down
1 change: 0 additions & 1 deletion x-pack/plugin/core/licenses/log4j-1.2-api-2.11.1.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions x-pack/plugin/core/licenses/log4j-1.2-api-2.15.0.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bc960fe2acbe6f3952011f88a771de18301534e7

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8bb417869ab3baa19f2fc70e6d776d041f0a8ebc

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8bb417869ab3baa19f2fc70e6d776d041f0a8ebc
2 changes: 0 additions & 2 deletions x-pack/plugin/sql/sql-action/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,9 @@ tasks.named("thirdPartyAudit").configure {
'org.apache.commons.compress.utils.IOUtils',
'org.apache.commons.csv.CSVFormat',
'org.apache.commons.csv.QuoteMode',
'org.apache.kafka.clients.producer.Callback',
'org.apache.kafka.clients.producer.Producer',
'org.apache.kafka.clients.producer.RecordMetadata',
'org.codehaus.stax2.XMLStreamWriter2',
'org.jctools.queues.MessagePassingQueue$Consumer',
'org.jctools.queues.MpscArrayQueue',
'org.osgi.framework.Bundle',
'org.osgi.framework.BundleActivator',
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
4a5aa7e55a29391c6f66e0b259d5189aa11e45d0

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ba55c13d7ac2fd44df9cc8074455719a33f375b9

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8bb417869ab3baa19f2fc70e6d776d041f0a8ebc

0 comments on commit 1089bd8

Please sign in to comment.