Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Произвольные обработчики ожидания выполнения процесса #41

Merged
merged 13 commits into from
Mar 4, 2019

Conversation

khorevaa
Copy link
Collaborator

  • механизм обработчиков
  • установка необходимости перехвата потоков
  • установка переменных среды в процесс

@khorevaa
Copy link
Collaborator Author

/cc @artbear

@khorevaa
Copy link
Collaborator Author

@artbear Есть ли замечания?

@artbear
Copy link
Owner

artbear commented Mar 1, 2019

@khorevaa я слил твой же МР, и теперь появились конфликты.

исправишь?

Copy link
Owner

@artbear artbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

падает добавленный тобой сценарий

и есть мелкие замечания по коду

исправишь?

src/Команда.os Outdated Show resolved Hide resolved
src/Команда.os Outdated Show resolved Hide resolved
features/wait-handler.feature Show resolved Hide resolved
src/Команда.os Outdated Show resolved Hide resolved
src/Команда.os Outdated Show resolved Hide resolved
@artbear
Copy link
Owner

artbear commented Mar 1, 2019

А в целом очень полезная функциональность.

@artbear artbear merged commit 77c595f into artbear:develop Mar 4, 2019
@artbear artbear added this to the 1.4 milestone Mar 4, 2019
@artbear
Copy link
Owner

artbear commented Apr 4, 2019

Связано с #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants