-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To new CLI #5
base: main
Are you sure you want to change the base?
To new CLI #5
Conversation
|
||
``` | ||
git clone [email protected]:art-e-fact/warp-client.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should keep the menton that you need to clone before doing the artefacts run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added on cloning under the Usage section. Does that flow well for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No tested, but seems good. I am fine with the test passing by default
``` | ||
git clone [email protected]:art-e-fact/warp-client.git | ||
docker build -t turtle2 . | ||
docker run --env ARTEFACTS_KEY=[YOUR-API-KEY] --net host --env DISPLAY=$DISPLAY -v $(pwd):/turtle turtle2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed it, but I don't see where you specify the -env DISPLAY=$DISPLAY
in the in-package
option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that necessary on Linux? For Darwin, and most likely Windows (TBC), it is done in the code.
I see that as part of CLI UX, so definitely interested in iterating toward very useful experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Andras if i recall correctly has been playing with displays with docker recently. He might have some insight on a more "bulletproof" x11-ing
E2E facilities do not support Galactic anymore. Galactic still works fine though.
This unit explains how to use the example with
artefacts run
and the newartefacts run --in-package
.It also changes a bit the approach:
Fine to get back to the original break-first version. Just found this way flowing better and didactic.
To give it a try:
Should work on Linux and Darwin. Chances it works on Windows. Both Darwin and Windows assume a well configured X11---not so easy and will document more.