Rename to toolkit #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ic
reviewed
Dec 9, 2024
README.md
Outdated
|
|
||
| Designed to be used with `artefacts-utils` this package contains code available under the GPL license. | ||
| Designed to be used with `artefacts-toolkit` this package contains code available under the GPL license. |
There was a problem hiding this comment.
Does it work standalone too, as a library on its own? Wondering whether there is transitivity of licence risk.
There was a problem hiding this comment.
It does yes. and the README notes how to use standalone.
Perhaps we should just not include in artefacts-toolkit-rosbag and artefacts-toolkit (so no umbrella wrapping). I believe that would make it "unmodified" when used, and thus not affecting licensing of the cli (if we include it in that) (?)
ic
approved these changes
Dec 9, 2024
|
I have renamed the func here to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renames utils to toolkit