Wrong aws_iam_authorization access key id setting (kedacore#1332)

* Wrong aws_iam_authorization access key id setting When getting the ACCESS_KEY_ID for AWS from Environment variables (which is currently the only working option), the `aws_iam_authorization` scaler would check if metadata.awsAccessKeyIDFromEnv was set, but it would then utilize the metadata.awsAccessKeyId for the name... while in the secretAccessKey it would then use the `FromEnv` one. This fixes that Signed-off-by: Xavier Geerinck <[email protected]> Signed-off-by: Aaron Schlesinger <[email protected]>
arschles · Nov 30, 2020 · 2d0b24e · 2d0b24e
1 parent d28dad0
commit 2d0b24e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,8 @@
 
 ### Improvements
 
+- Bug fix in aws_iam_authorization to utilize correct secret from env key name ([PR #1332](https://github.com/kedacore/keda/pull/1332))
+
 ### Breaking Changes
 
 ### Other

diff --git a/pkg/scalers/aws_iam_authorization.go b/pkg/scalers/aws_iam_authorization.go
@@ -30,7 +30,7 @@ func getAwsAuthorization(authParams, metadata, resolvedEnv map[string]string) (a
 			if metadata["awsAccessKeyID"] != "" {
 				meta.awsAccessKeyID = metadata["awsAccessKeyID"]
 			} else if metadata["awsAccessKeyIDFromEnv"] != "" {
-				meta.awsAccessKeyID = resolvedEnv[metadata["awsAccessKeyID"]]
+				meta.awsAccessKeyID = resolvedEnv[metadata["awsAccessKeyIDFromEnv"]]
 			}
 
 			if len(meta.awsAccessKeyID) == 0 {