-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.9 support #801
Conversation
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1713 1713
Branches 295 295
=========================================
Hits 1713 1713 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jadchaar looks solid man, kinda lame that GH actions doesn't support 3.9 yet but also funny that Travis is bailing us out here.
Speaking of which has Travis CI run on this PR, I don't see it?
I don't know why GH is not showing it. It might that GH prioritizes GH Actions now over Travis, which would be kind of funny if true. Here is the run: https://travis-ci.org/github/crsmithdev/arrow/builds/695468398. I had to find it by manually going to https://travis-ci.org/github/crsmithdev/arrow/. GH Actions is still developing and expanding, so hopefully we will see this dev/nightly support before 3.10 :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on my review, @krisfremen any comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than adding python 3.9 on windows for better coverage, looks great to me.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Adds support for Python 3.9 and pypy3 in
tox.ini
,Makefile
, and Travis CI.Github actions does not support development versions yet, but it is an open issue here: actions/setup-python#20.