Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.9 support #801

Merged
merged 10 commits into from
Jun 7, 2020
Merged

Add Python 3.9 support #801

merged 10 commits into from
Jun 7, 2020

Conversation

jadchaar
Copy link
Member

@jadchaar jadchaar commented Jun 6, 2020

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Adds support for Python 3.9 and pypy3 in tox.ini, Makefile, and Travis CI.

Github actions does not support development versions yet, but it is an open issue here: actions/setup-python#20.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #801 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #801   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1713      1713           
  Branches       295       295           
=========================================
  Hits          1713      1713           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a5676...69ec0fa. Read the comment docs.

@jadchaar jadchaar marked this pull request as ready for review June 6, 2020 17:54
@jadchaar jadchaar requested a review from systemcatch June 6, 2020 17:57
Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadchaar looks solid man, kinda lame that GH actions doesn't support 3.9 yet but also funny that Travis is bailing us out here.

Speaking of which has Travis CI run on this PR, I don't see it?

@jadchaar
Copy link
Member Author

jadchaar commented Jun 6, 2020

@jadchaar looks solid man, kinda lame that GH actions doesn't support 3.9 yet but also funny that Travis is bailing us out here.

Speaking of which has Travis CI run on this PR, I don't see it?

I don't know why GH is not showing it. It might that GH prioritizes GH Actions now over Travis, which would be kind of funny if true.

Here is the run: https://travis-ci.org/github/crsmithdev/arrow/builds/695468398. I had to find it by manually going to https://travis-ci.org/github/crsmithdev/arrow/.

GH Actions is still developing and expanding, so hopefully we will see this dev/nightly support before 3.10 :).

Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my review, @krisfremen any comments?

@systemcatch systemcatch requested a review from krisfremen June 6, 2020 22:58
@jadchaar jadchaar merged commit 95ce160 into arrow-py:master Jun 7, 2020
@jadchaar jadchaar deleted the feature/python39-support branch June 7, 2020 17:25
Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than adding python 3.9 on windows for better coverage, looks great to me.

.travis.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants