Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing_extensions #1176

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Conversation

lahwaacz
Copy link
Contributor

@lahwaacz lahwaacz commented Jun 22, 2024

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Removed typing_extensions imports which were used for python<3.8, but this package requires python>=3.8.

typing_extensions was used for python<3.8, but this package requires
python>=3.8
Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadchaar jadchaar merged commit 41717e5 into arrow-py:master Jun 23, 2024
18 checks passed
@lahwaacz lahwaacz deleted the typing_extensions branch June 23, 2024 17:20
Copy link

@blindmanchina blindmanchina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants