Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span_range returns unexpected result (missing days) when using frame month #1185

Open
Iwerzhon opened this issue Aug 26, 2024 · 2 comments · May be fixed by #1205
Open

span_range returns unexpected result (missing days) when using frame month #1185

Iwerzhon opened this issue Aug 26, 2024 · 2 comments · May be fixed by #1205
Labels

Comments

@Iwerzhon
Copy link

Issue Description

Describe the bug, including details regarding any error messages, version, and platform.

Sometimes (based on the start_date/end_date value), some days are missing when splitting a range of dates using span_range with frame=month

Doc: https://arrow.readthedocs.io/en/latest/api-guide.html#arrow.arrow.Arrow.span_range

Reproduction

import arrow
start_date = arrow.get("2023-01-31T00:00:00+02:00")
end_date = arrow.get("2024-08-20T16:08:09.538605+02:00")
[
    [start.isoformat(), end.isoformat()]
    for start, end in arrow.Arrow.span_range("month", start_date.datetime, end_date.datetime, exact=True)
]

Output

[
	['2023-01-31T00:00:00+02:00', '2023-02-27T23:59:59.999999+02:00'],
	['2023-02-28T00:00:00+02:00', '2023-03-27T23:59:59.999999+02:00'],
	['2023-03-31T00:00:00+02:00', '2023-04-29T23:59:59.999999+02:00'],  # missing 28th to 30th march
	['2023-04-30T00:00:00+02:00', '2023-05-29T23:59:59.999999+02:00'],
	['2023-05-31T00:00:00+02:00', '2023-06-29T23:59:59.999999+02:00'],
	['2023-06-30T00:00:00+02:00', '2023-07-29T23:59:59.999999+02:00'],
	['2023-07-31T00:00:00+02:00', '2023-08-30T23:59:59.999999+02:00'],
	['2023-08-31T00:00:00+02:00', '2023-09-29T23:59:59.999999+02:00'],
	['2023-09-30T00:00:00+02:00', '2023-10-29T23:59:59.999999+02:00'],
	['2023-10-31T00:00:00+02:00', '2023-11-29T23:59:59.999999+02:00'],
	['2023-11-30T00:00:00+02:00', '2023-12-29T23:59:59.999999+02:00'],
	['2023-12-31T00:00:00+02:00', '2024-01-30T23:59:59.999999+02:00'],
	['2024-01-31T00:00:00+02:00', '2024-02-28T23:59:59.999999+02:00'],
	['2024-02-29T00:00:00+02:00', '2024-03-28T23:59:59.999999+02:00'],
	['2024-03-31T00:00:00+02:00', '2024-04-29T23:59:59.999999+02:00'],
	['2024-04-30T00:00:00+02:00', '2024-05-29T23:59:59.999999+02:00'],
	['2024-05-31T00:00:00+02:00', '2024-06-29T23:59:59.999999+02:00'],
	['2024-06-30T00:00:00+02:00', '2024-07-29T23:59:59.999999+02:00'],
	['2024-07-31T00:00:00+02:00', '2024-08-20T16:08:09.538604+02:00'] # missing 30th july
]

Expected result

We should not miss any day from span_range. However, we...
go from 2023-03-27T23:59:59 to 2023-03-31T00:00:00+02:00, missing 3 days (2nd to 3rd value)
go from 2024-07-29T23:59:59 to 2024-07-31T00:00:00+02:00, missing 1 day (last value)

Note :

  • this issue may not occur with different dates
  • this issue does not occur when using frame=months instead of frame=month
  • this issue does not occur when not specifying exact=True

I am unsure of the difference between month and months, but I don't think this is the expected behavior?

System Info

  • 🖥 OS name and version: Windows 10.0.19045 (reproduced on MacOS)
  • 🐍 Python version: 3.9.6 (reproduced on 3.11)
  • 🏹 Arrow version: 1.3.0
@Iwerzhon Iwerzhon added the bug label Aug 26, 2024
@github-staff github-staff deleted a comment Aug 27, 2024
@rkendra
Copy link

rkendra commented Nov 6, 2024

Is anyone currently working on this? If not, I'd like to take a look into it. I was also able to reproduce the bug on Ubuntu 22.04.

@krisfremen
Copy link
Member

Is anyone currently working on this? If not, I'd like to take a look into it. I was also able to reproduce the bug on Ubuntu 22.04.

@rkendra not at the moment, feel free to take it up

rkendra added a commit to rkendra/arrow that referenced this issue Dec 5, 2024
@rkendra rkendra linked a pull request Dec 5, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@krisfremen @Iwerzhon @rkendra and others