Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flag for periodic GC invocation #565

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Conversation

millfreedom
Copy link
Contributor

@millfreedom millfreedom commented Aug 12, 2022

Description

Added flag for periodic GC invocation to reduce overall memory consuption in pooling scenarios (db1000nx100)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

manually tested

@millfreedom
Copy link
Contributor Author

@arriven Богдане, пінг.
Гляньте, чи можете прийняти PR.

Copy link
Owner

@arriven arriven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I feel like it would be more effective to just tune garbage collection via the GO_GC env variable, but at the same time this flag would allow us to check results more easily

Could also be helpful with issues like #555

@arriven arriven merged commit 13f4584 into arriven:main Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants