Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Lightsail support #488

Merged
merged 16 commits into from
Apr 4, 2022
Merged

AWS Lightsail support #488

merged 16 commits into from
Apr 4, 2022

Conversation

Amet13
Copy link
Contributor

@Amet13 Amet13 commented Apr 4, 2022

Description

AWS Lightsail support added

Fixes #224

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Test Configuration

  • Release version: latest
  • Platform: docker

Screenshot 2022-04-04 at 21 29 01

Screenshots

Screenshot 2022-04-04 at 21 28 49

@Amet13 Amet13 requested a review from arriven as a code owner April 4, 2022 18:34
@Amet13 Amet13 mentioned this pull request Apr 4, 2022
Closed
@arriven arriven merged commit ee21dbd into arriven:main Apr 4, 2022
@amaestr0
Copy link

amaestr0 commented Apr 5, 2022 •
edited
Loading

@arriven , has the multiple containers per service been added in scope of this changes?
Should existing containers be redeployed?

@Amet13
Copy link
Contributor Author

Amet13 commented Apr 5, 2022 •
edited
Loading

@amaestr0 you can scale containers by changing scale parameter in TF vars: https://github.com/Arriven/db1000n/blob/main/terraform/aws_lightsail/terraform.tfvars#L1

Should existing containers be redeployed?

They could be re-deployed, but it's not a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arriven arriven arriven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What about AWS Lightsail Containers?
3 participants
@Amet13 @amaestr0 @arriven