Reset metrics on config change #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea, but can we make it a separate set of metrics instead? Ideally we'd show users both the general amount of traffic and traffic for latest targets as simple reset would probably be a bit confusing |
|
Thinking about it more, I'll probably merge it as is since everything else works as if the app was restarted when config changes |
arriven
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the config is updated with new targets, metrics remain the same hence meaningless.
My little proposal is to reset metrics on each config update to get relevant information about current targets.
Sorry if anything is wrong, I learned Go yesterday.
Fixes # (issue)
N/A
Type of change
How Has This Been Tested?
TrafficandProcessedTrafficmetrics are reset.