Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure terraform config #431

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

neatdecisions
Copy link
Contributor

Description

Update the terraform config for Azure:

  • stop overriding container's commands (the default config URL was wrong);
  • propagate environment_variables and set ENABLE_PRIMITIVE: false.

Fixes # (issue)
Now terraform deployment for Azure can be launched right away without the need of configuration update, and disables primitive jobs by default (complementing #428)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

To test ENABLE_PRIMITIVE=false:

  • Test A: run terraform apply with the corrected config but without the environment variable setting: the number of jobs launched for 195.189.222.1:53 is 44 (as per current config: 22 TCP+22 UDP)
  • Test B: run terraform apply with the corrected config and with the environment variable setting (as in the PR): the number of jobs launched for 195.189.222.1:53 is 22 (as per current config: 22 TCP only) + "There is a filter defined for a job but this client doesn't pass it - skip the job" message in the logs.

Test Configuration

  • Release version: 0.8.4
  • Platform: Azure container instances

Screenshots

azure

@arriven arriven merged commit 6a263cf into arriven:main Mar 26, 2022
@neatdecisions neatdecisions deleted the fix/terraform-azure branch March 26, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants