Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the terraform config for Azure:
commands
(the default config URL was wrong);environment_variables
and setENABLE_PRIMITIVE: false
.Fixes # (issue)
Now terraform deployment for Azure can be launched right away without the need of configuration update, and disables primitive jobs by default (complementing #428)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
To test
ENABLE_PRIMITIVE=false
:terraform apply
with the corrected config but without the environment variable setting: the number of jobs launched for 195.189.222.1:53 is 44 (as per current config: 22 TCP+22 UDP)terraform apply
with the corrected config and with the environment variable setting (as in the PR): the number of jobs launched for 195.189.222.1:53 is 22 (as per current config: 22 TCP only) + "There is a filter defined for a job but this client doesn't pass it - skip the job" message in the logs.Test Configuration
Screenshots