Approx{1,2}_{v2,uniform}, af_gemm #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
approved these changes
Aug 20, 2020
| raise TypeError("unsupported input type") | ||
|
|
||
|
|
||
| safe_call(backend.get().af_gemm(c_pointer(out.arr), |
There was a problem hiding this comment.
Unrelated to this PR: I am curious if we have to do backend.get() for every such call. Is this cost negligible ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds approx functions from upstream 3.7. Writing to existing array is supported by the trailing
output=kargs.This PR also adds support for af_gemm. Adding a af_c{float,double}_t ctypes class was necessary as complex types aren't natively supported by ctypes (afaik).
TODO: Not sure how to best implement fp16 type