Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Fix NOAA hourly forecast #1051

Merged
merged 6 commits into from
Jan 13, 2022
Merged

Fix NOAA hourly forecast #1051

merged 6 commits into from
Jan 13, 2022

Conversation

dchassin
Copy link
Member

@dchassin dchassin commented Jan 4, 2022

This PR fixes issue #1050

Current issues

None

Code changes

  • Change NOAA property retrieved from "forecast" to "forecastHourly" in python_extras/noaa_forecast.py
  • Fix default output of CSV to /dev/stdout in python_extras/noaa_forecast.py

Documentation changes

None

Test and Validation Notes

Get the forecast and observe whether it makes sense, especially in the morning.

Try the following to quickly check the result:

gridlabd noaa_forecast -p=37.5,-122.2 | gridlabd plot -i=/dev/stdin -o=/tmp/test.png --plot:grid --show

@dchassin dchassin added the bug Request a fix or change to the code label Jan 4, 2022
@dchassin dchassin added this to the GRIP Final Release milestone Jan 4, 2022
@dchassin dchassin requested a review from aivanova5 January 4, 2022 04:24
@dchassin dchassin self-assigned this Jan 4, 2022
@dchassin dchassin linked an issue Jan 4, 2022 that may be closed by this pull request
@dchassin dchassin changed the title Update noaa_forecast.py Fix NOAA hourly forecast Jan 4, 2022
@dchassin dchassin mentioned this pull request Jan 4, 2022
23 tasks
@dchassin dchassin merged commit 1ee293f into develop Jan 13, 2022
@dchassin dchassin deleted the develop-fix-noaa-forecast branch January 13, 2022 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Request a fix or change to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noaa_forecast sometimes interpolates hourly forecast incorrectly
1 participant