First pass at updating the "create" command to be idempotent #82
Conversation
|
This isn't ready to ack yet. Rather, a work in progress where we can comment on the progress of the the issue. |
|
@aslakknutsen we have a first approach of reusing an existing container if it is already started. Now I think we must discuss which is the best strategy to follow. Discard to use an already started container automatically, by using a configuration parameter, ... It is true that reusing a container it should not be an automatic operation because it can be there something from previous execution. Also let suppose that the already started container have a link to another container, and that second container has just stopped correctly, then we have a problem because the container that is being reused is pointing out to a not created container. It seems that reusing a container is more complicated that we though (or at least me) initially. |
|
I set up an Ubuntu image with docker natively installed to check my changes, unfortunately they seem to have caused a problem with the native installation. I'll keep working on these changes and verify that they work in both environments. I'm having issues getting the existing tests in CubeControllerTest.should_enrich_test* to pass. There's no comments, and it's not immediately obvious to me what they are testing. Can you give me a rundown of what they should be testing so I can start looking at what has been broken with the config changes? |
|
I have just run the tests and they run and pass. |
| @@ -62,7 +65,7 @@ | |||
|
|
|||
| <container qualifier="tomcat_dockerfile"> | |||
| <configuration> | |||
| <property name="host">localhost</property> | |||
| <property name="host">${docker.tomcat.host}</property> | |||
There was a problem hiding this comment.
host isn't really needed here. It will be auto updated by Cube anyway.
|
Changing this into 2 pull requests. You can find them here. |
|
See #84 for fixing the docker ip issue |
Refactored endpoint and version to be maven properties. This allows users of boot2docker to override in their maven profile for testing. This PR will address issues #79 and #81.