-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrefixSet.PrefixSeq and PrefixSet.PrefixCompactSeq for Go 1.23+ #12
Comments
Hi @database64128, thanks for filing this issue. Iterators are definitely on my roadmap for this library. A PR would be much appreciated, if you're up for it. I'll get back to you about naming (and I'm open to further discussion about it). Relevant context: I have made an effort to mirror the naming patterns of netipx wherever it makes sense. While not perfect, this is part of an explicit goal of netipds to fit in with netip/netipx. |
Thanks. I went with |
Serializing large prefix sets will become much more efficient, if we can avoid allocating the intermediate slice by allowing iterator access over the prefixes. I propose we add:
Alternatively, give the existing
Prefixes
andPrefixesCompact
names to the new iterator methods, to align with the naming conventions.I'd be happy to work on this and open a PR.
Related proposal at netipx: go4org/netipx#21
The text was updated successfully, but these errors were encountered: