use install/uninstall hooks instead of add/remove hooks #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaces PR #872 fixes #869 Co-Authored-By: oborudko <[email protected]>
Co-Authored-By: oborudko <[email protected]>
|
@soumak77 since you refactored the scripts to be platform specific is there a reason you didn't do the same to the helpers. Seems odd to have some platform specific code in platform folders and other that is in a shared folder separated by only a naming convention. |
|
@briantq no specific reason. I'll refactor the helper scripts as well. |
|
@soumak77 on my train ride in I modified the script to put Google in allprojects so we follow the install guide to a T. I'll make a PR when I get into the office. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces PR #872
fixes #869
Co-Authored-By: @oborudko