Merge pull request #870 from wowmaking/ios-fetch-fix

iOS fetch method error resolving added
arnesson · Sep 27, 2018 · a92659a · a92659a
2 parents 923ebb5 + 0a56cde
commit a92659a
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/ios/FirebasePlugin.m b/src/ios/FirebasePlugin.m
@@ -332,17 +332,23 @@ - (void)fetch:(CDVInvokedUrlCommand *)command {
               int expirationDuration = [[command.arguments objectAtIndex:0] intValue];
 
               [remoteConfig fetchWithExpirationDuration:expirationDuration completionHandler:^(FIRRemoteConfigFetchStatus status, NSError * _Nullable error) {
+                  CDVPluginResult *pluginResult;
                   if (status == FIRRemoteConfigFetchStatusSuccess) {
-                      CDVPluginResult *pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
-                      [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
+                      pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
+                  } else {
+                      pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR];
                   }
+                  [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
               }];
           } else {
               [remoteConfig fetchWithCompletionHandler:^(FIRRemoteConfigFetchStatus status, NSError * _Nullable error) {
+                  CDVPluginResult *pluginResult;
                   if (status == FIRRemoteConfigFetchStatusSuccess) {
-                      CDVPluginResult *pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
-                      [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
+                      pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
+                  } else {
+                      pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR];
                   }
+                  [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
               }];
           }
     }];