Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status unknown #5

Closed
Druidblack opened this issue Nov 29, 2024 · 9 comments
Closed

Status unknown #5

Druidblack opened this issue Nov 29, 2024 · 9 comments

Comments

@Druidblack
Copy link

Good afternoon. After another reboot of jf. The plugin shows the unknown status. The refresh button does not help.

The plugin works at the same time. Is there anything that can be done to ensure that the status is always displayed correctly?

@Fabian1601
Copy link

Hello,
which version of jellyfin are you using?
I have jf 10.10.3 and I can also see the queries in Meilisearch, but nothing is faster in the search.
It is just as slow as without the plugin.
However, the status of the plugin has never been “OK” for me.
Greetings

@Druidblack
Copy link
Author

Druidblack commented Dec 5, 2024

Good afternoon. I also use jf 10.10.3. I have several instances of jf. And I use this plugin on all of them. In all use cases, I see queries in the meilisearch logs and the search has started to work faster. I have a library of 3,600 films, 62,000 episodes (16212 TV series) and 323861 songs. The difference in the search became immediately visible.

In meilisearch, in the web interface, do you see that your jf library has synchronized?

@Fabian1601
Copy link

Hello,
Yes, I can see all the entries in meilisearch and as you said, the search is almost instant.
In jf, however, it sometimes takes up to 10 seconds.
Which key did you use for the plugin? The admin key?

@Druidblack
Copy link
Author

yes

@arnesacnussem
Copy link
Owner

arnesacnussem commented Dec 14, 2024

Sorry for late replay, but I cant reproduce the unknown status while it working, the unknown is the default placeholder when status not loaded from /meilisearch/status endpoint, maybe you can check if your browser dev tool's "Network" tab to see if any clue.

It surely may load slow because every time accessing this endpoint, it will try to reconnect if the plugin is not connected to meilisearch server previously.

@Druidblack
Copy link
Author

I found the reason why the plugin does not show the status. There is a conflict when working with the InPlayerEpisodePreview https://github.com/Namo2/InPlayerEpisodePreviewplugin. When I turn it off, the status is displayed correctly.

@arnesacnussem
Copy link
Owner

arnesacnussem commented Jan 6, 2025

Their code here (Namo2/InPlayerEpisodePreview/DataFetcher.ts#L14) replaced window.fetch and caused some side effect, maybe you can open a issue there.
i'll see if i can find a workaround as for now.

the problem is DataFetcher.ts#L25, which try to resolve url passed to fetch, the url it trying to resolve is /meilisearch/status, when calling new URL("/meilisearch/status") this error will throw, the workaround i can imagine is to replace constructor of URL to ignore some certain path used by this plugin, or maybe I should pass full url to fetch?

Request failed to /meilisearch/status TypeError: Failed to construct 'URL': Invalid URL
VM846:80 TypeError: Failed to construct 'URL': Invalid URL
    at DataFetcher.<anonymous> (DataFetcher.ts:25:28)
    at Generator.next (<anonymous>)
    at fulfilled (AuthService.ts:23:2)

arnesacnussem added a commit that referenced this issue Jan 6, 2025
@arnesacnussem
Copy link
Owner

I choose to write this simple workaround because idk if ApiClient.get do more than just call fetch, this is included in release 1.10.1.1

@Druidblack
Copy link
Author

After updating the plugin, the status appeared. Thank you for promptly solving the problem from someone else's plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants