Skip to content

Commit

Permalink
Cleanup php 7 compatibility code (#564)
Browse files Browse the repository at this point in the history
  • Loading branch information
@arnaud-lb
arnaud-lb authored Oct 25, 2024
1 parent 15f54dc commit 13106ee
Show file tree
Hide file tree
Showing 11 changed files with 62 additions and 140 deletions.
8 changes: 4 additions & 4 deletions kafka_consumer.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -446,25 +446,25 @@ static void consumer_commit(int async, INTERNAL_FUNCTION_PARAMETERS) /* {{{ */
zval *zoffset;
rd_kafka_topic_partition_t *rktpar;

zerr = rdkafka_read_property(NULL, Z_RDKAFKA_PROP_OBJ(zarg), ZEND_STRL("err"), 0);
zerr = rdkafka_read_property(NULL, Z_OBJ_P(zarg), ZEND_STRL("err"), 0);
if (zerr && Z_TYPE_P(zerr) != IS_NULL && (Z_TYPE_P(zerr) != IS_LONG || Z_LVAL_P(zerr) != RD_KAFKA_RESP_ERR_NO_ERROR)) {
zend_throw_exception(ce_kafka_exception, "Invalid argument: Specified Message has an error", RD_KAFKA_RESP_ERR__INVALID_ARG);
return;
}

ztopic = rdkafka_read_property(NULL, Z_RDKAFKA_PROP_OBJ(zarg), ZEND_STRL("topic_name"), 0);
ztopic = rdkafka_read_property(NULL, Z_OBJ_P(zarg), ZEND_STRL("topic_name"), 0);
if (!ztopic || Z_TYPE_P(ztopic) != IS_STRING) {
zend_throw_exception(ce_kafka_exception, "Invalid argument: Specified Message's topic_name is not a string", RD_KAFKA_RESP_ERR__INVALID_ARG);
return;
}

zpartition = rdkafka_read_property(NULL, Z_RDKAFKA_PROP_OBJ(zarg), ZEND_STRL("partition"), 0);
zpartition = rdkafka_read_property(NULL, Z_OBJ_P(zarg), ZEND_STRL("partition"), 0);
if (!zpartition || Z_TYPE_P(zpartition) != IS_LONG) {
zend_throw_exception(ce_kafka_exception, "Invalid argument: Specified Message's partition is not an int", RD_KAFKA_RESP_ERR__INVALID_ARG);
return;
}

zoffset = rdkafka_read_property(NULL, Z_RDKAFKA_PROP_OBJ(zarg), ZEND_STRL("offset"), 0);
zoffset = rdkafka_read_property(NULL, Z_OBJ_P(zarg), ZEND_STRL("offset"), 0);
if (!zoffset || Z_TYPE_P(zoffset) != IS_LONG) {
zend_throw_exception(ce_kafka_exception, "Invalid argument: Specified Message's offset is not an int", RD_KAFKA_RESP_ERR__INVALID_ARG);
return;
Expand Down
32 changes: 16 additions & 16 deletions kafka_error_exception.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ void create_kafka_error(zval *return_value, const rd_kafka_error_t *error) /* {{

char message[1024];
snprintf(message, sizeof(message), "%s (RD_KAFKA_RESP_ERR_%s)", rd_kafka_error_string(error), rd_kafka_error_name(error));
zend_update_property_string(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("message"), message);
zend_update_property_string(ce_kafka_error, Z_OBJ_P(return_value), ZEND_STRL("message"), message);

zend_update_property_long(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("code"), rd_kafka_error_code(error));
zend_update_property_string(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("error_string"), rd_kafka_error_string(error));
zend_update_property_bool(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("isFatal"), rd_kafka_error_is_fatal(error));
zend_update_property_bool(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("isRetriable"), rd_kafka_error_is_retriable(error));
zend_update_property_bool(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("transactionRequiresAbort"), rd_kafka_error_txn_requires_abort(error));
zend_update_property_long(ce_kafka_error, Z_OBJ_P(return_value), ZEND_STRL("code"), rd_kafka_error_code(error));
zend_update_property_string(ce_kafka_error, Z_OBJ_P(return_value), ZEND_STRL("error_string"), rd_kafka_error_string(error));
zend_update_property_bool(ce_kafka_error, Z_OBJ_P(return_value), ZEND_STRL("isFatal"), rd_kafka_error_is_fatal(error));
zend_update_property_bool(ce_kafka_error, Z_OBJ_P(return_value), ZEND_STRL("isRetriable"), rd_kafka_error_is_retriable(error));
zend_update_property_bool(ce_kafka_error, Z_OBJ_P(return_value), ZEND_STRL("transactionRequiresAbort"), rd_kafka_error_txn_requires_abort(error));

Z_ADDREF_P(return_value);
}
Expand All @@ -60,12 +60,12 @@ PHP_METHOD(RdKafka_KafkaErrorException, __construct)
return;
}

zend_update_property_string(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("message"), message);
zend_update_property_long(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("code"), code);
zend_update_property_string(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("error_string"), error_string);
zend_update_property_bool(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("isFatal"), isFatal);
zend_update_property_bool(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("isRetriable"), isRetriable);
zend_update_property_bool(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("transactionRequiresAbort"), transactionRequiresAbort);
zend_update_property_string(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("message"), message);
zend_update_property_long(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("code"), code);
zend_update_property_string(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("error_string"), error_string);
zend_update_property_bool(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("isFatal"), isFatal);
zend_update_property_bool(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("isRetriable"), isRetriable);
zend_update_property_bool(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("transactionRequiresAbort"), transactionRequiresAbort);
}
/* }}} */

Expand All @@ -79,7 +79,7 @@ PHP_METHOD(RdKafka_KafkaErrorException, getErrorString)
return;
}

res = rdkafka_read_property(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("error_string"), 0);
res = rdkafka_read_property(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("error_string"), 0);

if (!res || Z_TYPE_P(res) != IS_STRING) {
return;
Expand All @@ -101,7 +101,7 @@ PHP_METHOD(RdKafka_KafkaErrorException, isFatal)
return;
}

res = rdkafka_read_property(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("isFatal"), 0);
res = rdkafka_read_property(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("isFatal"), 0);

if (!res || (Z_TYPE_P(res) != IS_TRUE && Z_TYPE_P(res) != IS_FALSE)) {
return;
Expand All @@ -122,7 +122,7 @@ PHP_METHOD(RdKafka_KafkaErrorException, isRetriable)
return;
}

res = rdkafka_read_property(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("isRetriable"), 0);
res = rdkafka_read_property(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("isRetriable"), 0);

if (!res || (Z_TYPE_P(res) != IS_TRUE && Z_TYPE_P(res) != IS_FALSE)) {
return;
Expand All @@ -143,7 +143,7 @@ PHP_METHOD(RdKafka_KafkaErrorException, transactionRequiresAbort)
return;
}

res = rdkafka_read_property(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("transactionRequiresAbort"), 0);
res = rdkafka_read_property(ce_kafka_error, Z_OBJ_P(getThis()), ZEND_STRL("transactionRequiresAbort"), 0);

if (!res || (Z_TYPE_P(res) != IS_TRUE && Z_TYPE_P(res) != IS_FALSE)) {
return;
Expand Down
24 changes: 12 additions & 12 deletions message.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,21 @@ void kafka_message_new(zval *return_value, const rd_kafka_message_t *message, ze
size_t header_size = 0;
size_t i;

zend_update_property_long(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("err"), message->err);
zend_update_property_long(NULL, Z_OBJ_P(return_value), ZEND_STRL("err"), message->err);

if (message->rkt) {
zend_update_property_string(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("topic_name"), rd_kafka_topic_name(message->rkt));
zend_update_property_string(NULL, Z_OBJ_P(return_value), ZEND_STRL("topic_name"), rd_kafka_topic_name(message->rkt));
}
zend_update_property_long(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("partition"), message->partition);
zend_update_property_long(NULL, Z_OBJ_P(return_value), ZEND_STRL("partition"), message->partition);
if (message->payload) {
zend_update_property_long(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("timestamp"), timestamp);
zend_update_property_stringl(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("payload"), message->payload, message->len);
zend_update_property_long(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("len"), message->len);
zend_update_property_long(NULL, Z_OBJ_P(return_value), ZEND_STRL("timestamp"), timestamp);
zend_update_property_stringl(NULL, Z_OBJ_P(return_value), ZEND_STRL("payload"), message->payload, message->len);
zend_update_property_long(NULL, Z_OBJ_P(return_value), ZEND_STRL("len"), message->len);
}
if (message->key) {
zend_update_property_stringl(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("key"), message->key, message->key_len);
zend_update_property_stringl(NULL, Z_OBJ_P(return_value), ZEND_STRL("key"), message->key, message->key_len);
}
zend_update_property_long(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("offset"), message->offset);
zend_update_property_long(NULL, Z_OBJ_P(return_value), ZEND_STRL("offset"), message->offset);

array_init(&headers_array);
if (message->err == RD_KAFKA_RESP_ERR_NO_ERROR) {
Expand All @@ -79,11 +79,11 @@ void kafka_message_new(zval *return_value, const rd_kafka_message_t *message, ze
}
}
}
zend_update_property(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("headers"), &headers_array);
zend_update_property(NULL, Z_OBJ_P(return_value), ZEND_STRL("headers"), &headers_array);
zval_ptr_dtor(&headers_array);

if (msg_opaque != NULL) {
zend_update_property_str(NULL, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("opaque"), msg_opaque);
zend_update_property_str(NULL, Z_OBJ_P(return_value), ZEND_STRL("opaque"), msg_opaque);
}
}

Expand Down Expand Up @@ -116,7 +116,7 @@ PHP_METHOD(RdKafka_Message, errstr)
return;
}

zerr = rdkafka_read_property(NULL, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("err"), 0);
zerr = rdkafka_read_property(NULL, Z_OBJ_P(getThis()), ZEND_STRL("err"), 0);

if (!zerr || Z_TYPE_P(zerr) != IS_LONG) {
return;
Expand All @@ -128,7 +128,7 @@ PHP_METHOD(RdKafka_Message, errstr)
RETURN_STRING(errstr);
}

zpayload = rdkafka_read_property(NULL, Z_RDKAFKA_PROP_OBJ(getThis()), ZEND_STRL("payload"), 0);
zpayload = rdkafka_read_property(NULL, Z_OBJ_P(getThis()), ZEND_STRL("payload"), 0);

if (zpayload && Z_TYPE_P(zpayload) == IS_STRING) {
RETURN_ZVAL(zpayload, 1, 0);
Expand Down
14 changes: 7 additions & 7 deletions metadata.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@ typedef struct _object_intern {
zend_object std;
} object_intern;

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp);
static HashTable *get_debug_info(zend_object *object, int *is_temp);

static zend_class_entry * ce;
static zend_object_handlers handlers;

static void brokers_collection(zval *return_value, Z_RDKAFKA_OBJ *parent, object_intern *intern) { /* {{{ */
static void brokers_collection(zval *return_value, zend_object *parent, object_intern *intern) { /* {{{ */
kafka_metadata_collection_init(return_value, parent, intern->metadata->brokers, intern->metadata->broker_cnt, sizeof(*intern->metadata->brokers), kafka_metadata_broker_ctor);
}
/* }}} */

static void topics_collection(zval *return_value, Z_RDKAFKA_OBJ *parent, object_intern *intern) { /* {{{ */
static void topics_collection(zval *return_value, zend_object *parent, object_intern *intern) { /* {{{ */
kafka_metadata_collection_init(return_value, parent, intern->metadata->topics, intern->metadata->topic_cnt, sizeof(*intern->metadata->topics), kafka_metadata_topic_ctor);
}
/* }}} */
Expand Down Expand Up @@ -91,7 +91,7 @@ static object_intern * get_object(zval *zmetadata)
return ometadata;
}

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */
static HashTable *get_debug_info(zend_object *object, int *is_temp) /* {{{ */
{
zval ary;
object_intern *intern;
Expand All @@ -102,7 +102,7 @@ static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */

array_init(&ary);

intern = rdkafka_get_debug_object(object_intern, object);
intern = php_kafka_from_obj(object_intern, object);
if (!intern || !intern->metadata) {
return Z_ARRVAL(ary);
}
Expand Down Expand Up @@ -175,7 +175,7 @@ PHP_METHOD(RdKafka_Metadata, getBrokers)
return;
}

brokers_collection(return_value, Z_RDKAFKA_PROP_OBJ(getThis()), intern);
brokers_collection(return_value, Z_OBJ_P(getThis()), intern);
}
/* }}} */

Expand All @@ -194,7 +194,7 @@ PHP_METHOD(RdKafka_Metadata, getTopics)
return;
}

topics_collection(return_value, Z_RDKAFKA_PROP_OBJ(getThis()), intern);
topics_collection(return_value, Z_OBJ_P(getThis()), intern);
}
/* }}} */

Expand Down
6 changes: 3 additions & 3 deletions metadata_broker.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ typedef struct _object_intern {
zend_object std;
} object_intern;

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp);
static HashTable *get_debug_info(zend_object *object, int *is_temp);

static zend_class_entry * ce;
static zend_object_handlers handlers;
Expand Down Expand Up @@ -80,7 +80,7 @@ static object_intern * get_object(zval *zmt)
return omt;
}

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */
static HashTable *get_debug_info(zend_object *object, int *is_temp) /* {{{ */
{
zval ary;
object_intern *intern;
Expand All @@ -89,7 +89,7 @@ static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */

array_init(&ary);

intern = rdkafka_get_debug_object(object_intern, object);
intern = php_kafka_from_obj(object_intern, object);
if (!intern || !intern->metadata_broker) {
return Z_ARRVAL(ary);
}
Expand Down
10 changes: 5 additions & 5 deletions metadata_collection.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ typedef struct _object_intern {
zend_object std;
} object_intern;

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp);
static HashTable *get_debug_info(zend_object *object, int *is_temp);

static zend_class_entry *ce;
static zend_object_handlers handlers;
Expand Down Expand Up @@ -85,7 +85,7 @@ static object_intern * get_object(zval *zmti)
return omti;
}

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */
static HashTable *get_debug_info(zend_object *object, int *is_temp) /* {{{ */
{
zval ary;
object_intern *intern;
Expand All @@ -96,7 +96,7 @@ static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */

array_init(&ary);

intern = rdkafka_get_debug_object(object_intern, object);
intern = php_kafka_from_obj(object_intern, object);
if (!intern || !intern->items) {
return Z_ARRVAL(ary);
}
Expand Down Expand Up @@ -246,7 +246,7 @@ void kafka_metadata_collection_minit(INIT_FUNC_ARGS)
handlers.offset = XtOffsetOf(object_intern, std);
}

void kafka_metadata_collection_init(zval *return_value, Z_RDKAFKA_OBJ *zmetadata, const void * items, size_t item_cnt, size_t item_size, kafka_metadata_collection_ctor_t ctor)
void kafka_metadata_collection_init(zval *return_value, zend_object *zmetadata, const void * items, size_t item_cnt, size_t item_size, kafka_metadata_collection_ctor_t ctor)
{
object_intern *intern;

Expand All @@ -259,7 +259,7 @@ void kafka_metadata_collection_init(zval *return_value, Z_RDKAFKA_OBJ *zmetadata
return;
}

Z_RDKAFKA_OBJ_COPY(&intern->zmetadata, zmetadata);
ZVAL_OBJ_COPY(&intern->zmetadata, zmetadata);
intern->items = items;
intern->item_cnt = item_cnt;
intern->item_size = item_size;
Expand Down
2 changes: 1 addition & 1 deletion metadata_collection.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
typedef void (*kafka_metadata_collection_ctor_t)(zval *renurn_value, zval *zmetadata, const void *object);

void kafka_metadata_collection_minit(INIT_FUNC_ARGS);
void kafka_metadata_collection_init(zval *return_value, Z_RDKAFKA_OBJ *zmetadata, const void * items, size_t item_cnt, size_t item_size, kafka_metadata_collection_ctor_t ctor);
void kafka_metadata_collection_init(zval *return_value, zend_object *zmetadata, const void * items, size_t item_cnt, size_t item_size, kafka_metadata_collection_ctor_t ctor);
10 changes: 5 additions & 5 deletions metadata_partition.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ typedef struct _object_intern {
zend_object std;
} object_intern;

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp);
static HashTable *get_debug_info(zend_object *object, int *is_temp);

static zend_class_entry * ce;
static zend_object_handlers handlers;
Expand Down Expand Up @@ -81,7 +81,7 @@ static object_intern * get_object(zval *zmt)
return omt;
}

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */
static HashTable *get_debug_info(zend_object *object, int *is_temp) /* {{{ */
{
zval ary;
object_intern *intern;
Expand All @@ -90,7 +90,7 @@ static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */

array_init(&ary);

intern = rdkafka_get_debug_object(object_intern, object);
intern = php_kafka_from_obj(object_intern, object);
if (!intern || !intern->metadata_partition) {
return Z_ARRVAL(ary);
}
Expand Down Expand Up @@ -181,7 +181,7 @@ PHP_METHOD(RdKafka_Metadata_Partition, getReplicas)
return;
}

kafka_metadata_collection_init(return_value, Z_RDKAFKA_PROP_OBJ(getThis()), intern->metadata_partition->replicas, intern->metadata_partition->replica_cnt, sizeof(*intern->metadata_partition->replicas), int32_ctor);
kafka_metadata_collection_init(return_value, Z_OBJ_P(getThis()), intern->metadata_partition->replicas, intern->metadata_partition->replica_cnt, sizeof(*intern->metadata_partition->replicas), int32_ctor);
}
/* }}} */

Expand All @@ -200,7 +200,7 @@ PHP_METHOD(RdKafka_Metadata_Partition, getIsrs)
return;
}

kafka_metadata_collection_init(return_value, Z_RDKAFKA_PROP_OBJ(getThis()), intern->metadata_partition->isrs, intern->metadata_partition->isr_cnt, sizeof(*intern->metadata_partition->isrs), int32_ctor);
kafka_metadata_collection_init(return_value, Z_OBJ_P(getThis()), intern->metadata_partition->isrs, intern->metadata_partition->isr_cnt, sizeof(*intern->metadata_partition->isrs), int32_ctor);
}
/* }}} */

Expand Down
10 changes: 5 additions & 5 deletions metadata_topic.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ typedef struct _object_intern {
zend_object std;
} object_intern;

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp);
static HashTable *get_debug_info(zend_object *object, int *is_temp);

static zend_class_entry * ce;
static zend_object_handlers handlers;

static void partitions_collection(zval *return_value, Z_RDKAFKA_OBJ *parent, object_intern *intern) { /* {{{ */
static void partitions_collection(zval *return_value, zend_object *parent, object_intern *intern) { /* {{{ */
kafka_metadata_collection_init(return_value, parent, intern->metadata_topic->partitions, intern->metadata_topic->partition_cnt, sizeof(*intern->metadata_topic->partitions), kafka_metadata_partition_ctor);
}
/* }}} */
Expand Down Expand Up @@ -87,7 +87,7 @@ static object_intern * get_object(zval *zmt)
return omt;
}

static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */
static HashTable *get_debug_info(zend_object *object, int *is_temp) /* {{{ */
{
zval ary;
object_intern *intern;
Expand All @@ -97,7 +97,7 @@ static HashTable *get_debug_info(Z_RDKAFKA_OBJ *object, int *is_temp) /* {{{ */

array_init(&ary);

intern = rdkafka_get_debug_object(object_intern, object);
intern = php_kafka_from_obj(object_intern, object);
if (!intern || !intern->metadata_topic) {
return Z_ARRVAL(ary);
}
Expand Down Expand Up @@ -168,7 +168,7 @@ PHP_METHOD(RdKafka_Metadata_Topic, getPartitions)
return;
}

partitions_collection(return_value, Z_RDKAFKA_PROP_OBJ(getThis()), intern);
partitions_collection(return_value, Z_OBJ_P(getThis()), intern);
}
/* }}} */

Expand Down
Loading

0 comments on commit 13106ee

Please sign in to comment.