Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): add sprig functions to parser (fixes armory/dinghy#113) #122

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

haisum
Copy link
Contributor

@haisum haisum commented Dec 10, 2020

This PR adds sprig functions to go templates. Sprig is included in helm and other popular projects using go templates. Without these functions, simple things like splitting string, indenting YAML, trimming whitespace are not possible in dinghy templates.

@coveralls
Copy link

coveralls commented Dec 10, 2020

Coverage Status

Coverage decreased (-0.6%) to 52.992% when pulling d2eb2d8 on haisum:feature/springv3-functions into fefce83 on armory:master.

@dogonthehorizon
Copy link
Contributor

Hey @haisum ! Thank you so much for the PR :) I'll commit to reviewing this in more detail today, expect to hear by EOD PST!

@Jossuecito
Copy link
Contributor

I made a test in arm-cli with the change and found a small bug, now it should be fine. Thanks for the PR!! 😸

Copy link
Contributor

@Jossuecito Jossuecito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jossuecito Jossuecito changed the title feat(parser): add sprig functions to parser (fixes armory/dinghy#113) feat(parser): add sprig functions to parser (fixes armory/dinghy#113) Dec 21, 2020
@Jossuecito Jossuecito changed the title feat(parser): add sprig functions to parser (fixes armory/dinghy#113) feat(parser): add sprig functions to parser Dec 21, 2020
@Jossuecito Jossuecito changed the title feat(parser): add sprig functions to parser feat(parser): add sprig functions to parser (fixes armory/dinghy#113) Dec 21, 2020
@Jossuecito Jossuecito merged commit aa78259 into armory:master Dec 21, 2020
dogonthehorizon pushed a commit that referenced this pull request Mar 30, 2021
* feat(parser): add sprig functions to parser (fixes #113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants