Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UEFI kernels, legacy = 6.6, current 6.12 & edge 6.13 #7717

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jan 18, 2025

Description

  • switching sources
  • move kernel configs
  • drop patches for 6.1

How Has This Been Tested?

  • CI builds, 6.6 and 6.12 x86 booting on VM and HW

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress Build Executing build train (permission needed) 02 Milestone: First quarter release labels Jan 18, 2025
@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jan 18, 2025
@igorpecovnik igorpecovnik removed the Work in progress Unfinished / work in progress label Jan 19, 2025
@igorpecovnik igorpecovnik changed the title UEFI kernels, legacy = 6.6, current & edge 6.12 UEFI kernels, legacy = 6.6, current 6.12 & edge 6.13 Jan 19, 2025
@igorpecovnik igorpecovnik requested a review from a team as a code owner January 19, 2025 13:57
@github-actions github-actions bot added the Framework Framework components label Jan 19, 2025
@igorpecovnik igorpecovnik removed the Build Executing build train (permission needed) label Jan 19, 2025
@igorpecovnik igorpecovnik force-pushed the bump_uefi branch 8 times, most recently from b093bf9 to 3db8f66 Compare January 19, 2025 18:29
@igorpecovnik
Copy link
Member Author

igorpecovnik commented Jan 19, 2025

@amazingfate Saw your patch upstream but still I wasn't been able to compile driver_rtl8189ES or driver_rtl8189FS on 6.13.RC

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jan 19, 2025
@igorpecovnik igorpecovnik merged commit dc558d7 into main Jan 19, 2025
10 checks passed
@igorpecovnik igorpecovnik deleted the bump_uefi branch January 19, 2025 19:21
@amazingfate
Copy link
Contributor

I only tested rtl8189es with rockchip64-6.13: https://paste.next.armbian.com/etozibivaf
Do you have error log on other branches?

@igorpecovnik
Copy link
Member Author

Do you have error log on other branches?

https://paste.armbian.de/ukibovudis

@amazingfate
Copy link
Contributor

The missing ieee80211_ptr depends on CONFIG_CFG80211, rockchip64 has it enabled so it's fine.
This is introduced since v5.19: torvalds/linux@c304edd

@igorpecovnik
Copy link
Member Author

So we need to enable CONFIG_CFG80211 on those that breaks?

@amazingfate
Copy link
Contributor

I get the same error after disabling CONFIG_CFG80211 in rockchip64-6.13. After a quick look at the dkms source Makefile, that is really a mess and I think enabling CONFIG_CFG80211 at our side is an easier way.
Maybe we can enable this config by default when extra wifi is enabled just like we enable BTF @rpardini ?

@igorpecovnik
Copy link
Member Author

Maybe we can enable this config by default when extra wifi is enabled just like we enable BTF

What is easier and quicker? I think this can be enabled by default. Probably won't hurt?

@rpardini
Copy link
Member

Maybe we can enable this config by default when extra wifi is enabled just like we enable BTF @rpardini ?

Yes this can be done directly in a hook, so we don't need to go updating each .config individually.

@rpardini
Copy link
Member

I seem to have similar error related to CONFIG_CFG80211 on meson64's try to bump to 6.13 (#7727 (comment))

@rpardini
Copy link
Member

It seems not only EXTRAWIFI drivers are affected, in-kernel drivers are also disabled because of missing CONFIG_CFG80211. Since we run oldconfig early in the process, it ends up disabling a lot of drivers. I'm looking into running the kernel config hooks before running oldconfig so we can correct for this in time.

@rpardini
Copy link
Member

@amazingfate @igorpecovnik try this one? #7728 -- it fixes the build for meson64 driver_rtl88x2cs on 6.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

3 participants