Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armbian-install UEFI: EFI partition generation, hiding non Linux partitions #7631

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jan 1, 2025

Description

UEFI installation is partially broken. This is an attempt to fix it and harden the method.

  • not automatically generate one ext4 partition when UEFI is selected
  • when asking on which partition to install, hide all but Linux partition

How Has This Been Tested?

  • Tested installing side by side with Windows
  • Tested installing on eMMC (which was anyway not affected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress Bugfix Pull request is fixing a bug 02 Milestone: First quarter release labels Jan 1, 2025
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review BSP Board Support Packages labels Jan 1, 2025
@igorpecovnik igorpecovnik marked this pull request as ready for review January 5, 2025 09:37
@igorpecovnik igorpecovnik requested a review from a team as a code owner January 5, 2025 09:37
@igorpecovnik igorpecovnik removed the Work in progress Unfinished / work in progress label Jan 5, 2025
@igorpecovnik igorpecovnik changed the title UEFI: bugfix generation EFI partition armbian-install UEFI: EFI partition generation, hiding non Linux partitions Jan 5, 2025
@igorpecovnik igorpecovnik merged commit dfe55bc into main Jan 11, 2025
10 checks passed
@igorpecovnik igorpecovnik deleted the armbian-install branch January 11, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release BSP Board Support Packages Bugfix Pull request is fixing a bug Needs review Seeking for review size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

1 participant