Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board config for MXQ TV box #7501

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add board config for MXQ TV box #7501

wants to merge 3 commits into from

Conversation

domin144
Copy link

@domin144 domin144 commented Nov 19, 2024

Description

This change introduces a config for MXQ TV box based on S805 chip. This revives the s805_autoscript file, which is being sought for by the factory boot loader, making it possible to boot from SD card.

How Has This Been Tested?

I built an image with:

./compile.sh build BOARD=aml-s805-mxq BRANCH=edge BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED='browsers internet multimedia' DESKTOP_ENVIRONMENT=xfce DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base KERNEL_CONFIGURE=no RELEASE=bookworm

I flashed an image on an SD card and booted the board. I was able to run xserver with display connected on integrated HDMI port and use mouse and keyboard connected to USB ports. Ethernet connection was working too.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Notice

This is my first PR to this project, so any advice is appreciated. The board support and testing is not of high quality, but should not affect any other board and give good starting point for further work. Prior to these changes running armbian on the MXQ board requires non-trivial, manual adjustments to the image.

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Nov 19, 2024
@igorpecovnik igorpecovnik added the 02 Milestone: First quarter release label Nov 20, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Dec 6, 2024
@igorpecovnik
Copy link
Member

This is my first PR to this project, so any advice is appreciated.

Check if you can make use of existing boot scripts.

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress and removed Ready to merge Reviewed, tested and ready for merge labels Dec 13, 2024
@domin144
Copy link
Author

This is my first PR to this project, so any advice is appreciated.

Check if you can make use of existing boot scripts.

Odroid-c1 and onecloud are the closest boards, but neither script will work out of the box due to hard-coded dtb path. I could try to extend one of those scripts, but this is additional risk of breaking those boards (I have no access to those boards to test). I think it should better be done under a separate PR.

Built-in U-BOOT is used, so the logo will not be displayed anyway.
@domin144
Copy link
Author

domin144 commented Feb 4, 2025

I tried unifying the s805 boot scripts. Most of the code could be common. The dtb file could be selected in armbianEnv.txt.

Yet, MXQ cannot use exactly same script, as it detects the bootdev variable by looking for s805_autoscript, while odroid-c1 does not use the variable at all and onecloud expects it to be provided externally.

bootdev is needed to read the armbianEnv.txt config, so the config cannot be used to switch between the three approaches.

@igorpecovnik
Copy link
Member

Yet, MXQ cannot use exactly same script

OK, understand. Another thing. In the mean time, kernel v6.12 becomes the thing and next release target. Move it to that folder and test, then we merge this.

@domin144
Copy link
Author

domin144 commented Feb 4, 2025

I can't see meson kernel updated on main. Do you refer to meson64 kernel? MXQ has a 32-bit processor.

@igorpecovnik
Copy link
Member

I can't see meson kernel updated on main.

Yes, it hasn't been switched for all kernels. Having 6.12. on current is general wish / target. Feel free to do it - if it works for you, there are great chanches it will work for other devices. Anyway, none is one the officially supported list ...

https://github.com/armbian/build/blob/main/config/sources/families/include/meson_common.inc

@igorpecovnik
Copy link
Member

Related: #7747

@domin144
Copy link
Author

domin144 commented Feb 6, 2025

I can see that #7747 has a different set of patches and there is discussion on which kernel versions should be assigned to legacy, current and edge labels. These changes are possibly breaking. I am happy to follow and test the updated kernel later, but I really think we should not mix the things.

This change only introduces config, scripts and a single patch to device tree for the MXQ. It should not affect anything else. I don't want to mix it, with a kernel update and a new set of patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/medium PR with more then 50 and less then 250 lines Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

2 participants