Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update armbian-ramlog #6024

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Update armbian-ramlog #6024

merged 1 commit into from
Dec 9, 2023

Conversation

JuergenBausa
Copy link
Contributor

Original version destroyed journal on command postrotate as files in /var/log.hdd/journal are overwritten by cat. With the patch journal is not damaged anymore.

Description

In original version in postrotate files in /var/log.hdd/journal are deleted by the command

dest="/var/log/$file"
cat $file > $dest

as /var/log/journal is a symling to /var/log.hdd/journal files are cated on themselves which ends up with an empty file.

How Has This Been Tested?

check journal by journactl. There is no data earlier than today 0:00.
Also "journalctl --verify" shows that journal is damaged.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Original version destroyed journal on command postrotate as files in /var/log.hdd/journal are overwritten by cat. With the patch journal is not damaged anymore.
@JuergenBausa JuergenBausa requested a review from a team as a code owner December 8, 2023 22:29
@github-actions github-actions bot added the size/small PR with less then 50 lines label Dec 8, 2023
@igorpecovnik igorpecovnik added 02 Milestone: First quarter release Needs review Seeking for review labels Dec 9, 2023
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Bugfix Pull request is fixing a bug and removed Needs review Seeking for review labels Dec 9, 2023
@igorpecovnik igorpecovnik merged commit 67e0bb2 into armbian:main Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Bugfix Pull request is fixing a bug Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants