Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep empty line in armbianEnv.txt #4077

Closed
wants to merge 1 commit into from
Closed

Keep empty line in armbianEnv.txt #4077

wants to merge 1 commit into from

Conversation

hzyitc
Copy link
Member

@hzyitc hzyitc commented Aug 16, 2022

Description

Keep empty line in armbianEnv.txt

How Has This Been Tested?

  • Test A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik
Copy link
Member

Can't understand if this change is good, needed or not.

@hzyitc
Copy link
Member Author

hzyitc commented Aug 19, 2022

I add some comment into armbianEnv.txt to explain the options, so I need some empty line to split the lines.

@hzyitc hzyitc force-pushed the armbianEnv-keep-empty-line branch from 6d40a78 to 8b92576 Compare November 18, 2022 03:29
@Kreyren
Copy link
Contributor

Kreyren commented Mar 4, 2023

@hzyitc Is this stale? -> Close

Is something still needed? -> Elaborate

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress 23.08 labels May 19, 2023
@igorpecovnik igorpecovnik added Backlog Stalled work that needs to be completed and removed 23.08 Work in progress Unfinished / work in progress labels Nov 15, 2023
Wikeolf added a commit to Wikeolf/armbian-onecloud that referenced this pull request Jan 8, 2024
@Wikeolf
Do not patch armbian#4077
f9933bb
Wikeolf added a commit to Wikeolf/armbian-onecloud that referenced this pull request Jan 8, 2024
@Wikeolf
hand patch armbian#4077
d6b2de2
Wikeolf added a commit to Wikeolf/armbian-onecloud that referenced this pull request Jan 8, 2024
@Wikeolf
Do not patch armbian#4077, only build jammy legacy minimal and cli ve…
0f09fc1 
…rsion with btrfs rootfs
@ColorfulRhino
Copy link
Collaborator

🧹 PR Cleanup Quest 🧹

Ping @hzyitc

@ColorfulRhino ColorfulRhino added the Can be closed? Ping developers on stalled issue / PR label Jun 25, 2024
@ColorfulRhino
Copy link
Collaborator

No response after a few weeks. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backlog Stalled work that needs to be completed Can be closed? Ping developers on stalled issue / PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzyitc @igorpecovnik @Kreyren @ColorfulRhino