Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further stabilize ethernet of rockpi-4b #1821

Closed
wants to merge 1 commit into from

Conversation

fraz0815
Copy link

This pull 1736 was a good start for improving network stability.
snps,txpbl = <0x4>;

But in my case, or I guess with a typical german ISP with DS-lite (Native IPv6 + IPv4 tunneling through IPv6 - it is a nightmare in general). I did not use the board much because it was only usuable with
ethtool -K eth0 tx off rx off. Turns out the above pull request improved situation, but I was still unable to complete a simple apt update. After checking some other fixes around I also increased rx_delay = <0x20>; and all my problems are gone for the first time and I am actually using this board. The setting could possibly use some fine tuning, maybe 16 is already enough.

@chwe17
Copy link
Member

chwe17 commented Feb 29, 2020

please check:
#546
and/or
https://github.com/ayufan-rock64/linux-build/blob/02fae982767ca242009baaf995f7ce64b5d82469/recipes/gmac-delays-test/range-test

so that we come up with settings based on proper testing. @ThomasKaiser script might need some adjustments cause it seems we deal with much higher rx/tx delays as as we did on H64 for what it was written in the first time.

@fraz0815
Copy link
Author

Okay thanks, interesting scripts. Will start testing tomorrow after work

Copy link
Member

@piter75 piter75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention Rock Pi 4 but you actually modify the device tree of NanoPC/Pi family.
Does the change really fix the issue for you?

Would you mind verifying and providing similar patch for "-dev" while you are at it?

@@ -0,0 +1,13 @@
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make the patch name consistent with the ones that are already there.
board-rockpi4-dts-rx-delay-tweak.patch would fit better what we already have IMHO ;-)

@piter75
Copy link
Member

piter75 commented Feb 29, 2020

I see that you have opened another PR with eMMC fixes for NanoPC T4... Maybe this one should also addresses issues with NanoPC T4.

If so the patch name should be corrected and the change should be addressed at board's level device tree similarly to this one.

@fraz0815
Copy link
Author

I own both boards, nanopct4 and rockpi-4b, and both have some quirks (nanopct4 -> emmc, rockpi-4b -> broken ethernet packets) out of the box.

I just messed the patch totally up, should have gone sleeping, wtf.

Please excuse me, and let me doublecheck what happened here and why I picked that one and why it actually helped :-/

@fraz0815
Copy link
Author

fraz0815 commented Mar 2, 2020

I am closing this one, as the patch was messed up (wrong targeted dtsi).
I am starting to understand the test scripts mentionend and making the needed changes.

This will take some time to test and interpret the results.
Data to discuss will follow in a few days.

@fraz0815 fraz0815 closed this Mar 2, 2020
@fraz0815 fraz0815 deleted the patch-3 branch March 3, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants