Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted txpbl for rk3399 to fix network issues with MTU 1500 #1736

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Adjusted txpbl for rk3399 to fix network issues with MTU 1500 #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions patch/kernel/rockchip64-current/rk3399-adjust-txpbl-for-mtu-1500.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
Default Programmable Buffer Length for TX in rk3399's gmac is not suitable
for MTUs higher than 1498. The easiest solution would be to disable
TX offloading but it is not ideal as it disables hardware checksumming.

This patch sets txpbl to 0x4 which is good for the most popular MTU
value of 1500.

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index cede1ad81..02674bbf0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -288,6 +288,7 @@
resets = <&cru SRST_A_GMAC>;
reset-names = "stmmaceth";
rockchip,grf = <&grf>;
+ snps,txpbl = <0x4>;
status = "disabled";
};

19 changes: 19 additions & 0 deletions patch/kernel/rockchip64-dev/rk3399-adjust-txpbl-for-mtu-1500.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
Default Programmable Buffer Length for TX in rk3399's gmac is not suitable
for MTUs higher than 1498. The easiest solution would be to disable
TX offloading but it is not ideal as it disables hardware checksumming.

This patch sets txpbl to 0x4 which is good for the most popular MTU
value of 1500.

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index cede1ad81..02674bbf0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -288,6 +288,7 @@
resets = <&cru SRST_A_GMAC>;
reset-names = "stmmaceth";
rockchip,grf = <&grf>;
+ snps,txpbl = <0x4>;
status = "disabled";
};