fix typo in controller and typo in validation error for min_sales_per…

…_txn>max_sales_per_txn
armandofox · Oct 20, 2023 · a2f1130 · a2f1130
1 parent d22ba17
commit a2f1130
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/controllers/valid_vouchers_controller.rb b/app/controllers/valid_vouchers_controller.rb
@@ -85,7 +85,7 @@ def set_arg_defaults_if_blank!(args)
     # this should be done with strong params
     # supply defaults for min/max_sales_for_type and max_sales_per_txn if blank
     args[:min_sales_per_txn] = 1 if args[:min_sales_per_txn].blank?
-    args[:max_sales_for_type, :max_sales_per_txn].each do |attrib|
+    [:max_sales_for_type, :max_sales_per_txn].each do |attrib|
       args[attrib] = ValidVoucher::INFINITE if args[attrib].blank?
     end
   end

diff --git a/app/models/valid_voucher.rb b/app/models/valid_voucher.rb
@@ -116,7 +116,7 @@ def self_service_comps_must_have_promo_code
   def min_max_sales_constraints
     errors.add :min_sales_per_txn, "cannot be greater than max allowed sales of this type"  if
       min_sales_per_txn > max_sales_for_type
-    errors.add :min_sales_per_txn, "cannot be greater than minimum purchase per transaction" if
+    errors.add :min_sales_per_txn, "cannot be greater than maximum purchase per transaction" if
       min_sales_per_txn > max_sales_per_txn
     errors.empty?
   end