Enable expose profiling port for remaining charts, better profiling error handling

deployment/armada/templates/deployment.yaml

@@ -72,7 +72,7 @@ spec:
             {{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
             - containerPort: {{ .Values.applicationConfig.profiling.port }}
               protocol: TCP
-              name: pprof
+              name: profiling
             {{- end }}
           volumeMounts:
             - name: user-config

deployment/armada/templates/profiling-ingress.yaml

@@ -0,0 +1,35 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.hostnames }}
+{{- $root := . -}}
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  name: {{ include "armada.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  annotations:
+    certmanager.k8s.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+    cert-manager.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+  labels:
+    {{- include "armada.labels.all" . | nindent 4 }}
+spec:
+  rules:
+  {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+  - host: {{ .  }}
+    http:
+      paths:
+        - path: /
+          pathType: Prefix
+          backend:
+            service:
+              name: {{ include "armada.name" $root }}-server-profiling
+              port:
+                number: {{ $root.Values.applicationConfig.profiling.port }}
+  {{ end -}}
+  tls:
+    - hosts:
+       {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+      - {{ . -}}
+       {{ end }}
+      secretName: {{ include "armada.name" $root }}-profiling-service-tls
+---
+{{- end }}
+

deployment/armada/templates/profiling-service.yaml

@@ -0,0 +1,19 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ include "armada.name" . }}-server-profiling
+  namespace: {{ .Release.Namespace }}
+  labels:
+    {{- include "armada.labels.all" . | nindent 4 }}
+    name: {{ include "armada.name" . }}-profiling
+spec:
+  selector:
+    app: {{ include "armada.name" . }}
+  ports:
+    - name: profiling
+      protocol: TCP
+      port: {{ .Values.applicationConfig.profiling.port }}
+---
+{{- end }}
+

deployment/binoculars/templates/deployment.yaml

@@ -57,7 +57,7 @@ spec:
             {{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
             - containerPort: {{ .Values.applicationConfig.profiling.port }}
               protocol: TCP
-              name: pprof
+              name: profiling
             {{- end }}
           volumeMounts:
             - name: user-config

deployment/binoculars/templates/profiling-ingress.yaml

@@ -0,0 +1,35 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.hostnames }}
+{{- $root := . -}}
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  name: {{ include "binoculars.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  annotations:
+    certmanager.k8s.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+    cert-manager.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+  labels:
+    {{- include "binoculars.labels.all" . | nindent 4 }}
+spec:
+  rules:
+  {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+  - host: {{ .  }}
+    http:
+      paths:
+        - path: /
+          pathType: Prefix
+          backend:
+            service:
+              name: {{ include "binoculars.name" $root }}-profiling
+              port:
+                number: {{ $root.Values.applicationConfig.profiling.port }}
+  {{ end -}}
+  tls:
+    - hosts:
+       {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+      - {{ . -}}
+       {{ end }}
+      secretName: {{ include "binoculars.name" $root }}-profiling-service-tls
+---
+{{- end }}
+

deployment/binoculars/templates/profiling-service.yaml

@@ -0,0 +1,19 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ include "binoculars.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  labels:
+    {{- include "binoculars.labels.all" . | nindent 4 }}
+    name: {{ include "binoculars.name" . }}-profiling
+spec:
+  selector:
+    app: {{ include "binoculars.name" . }}
+  ports:
+    - name: profiling
+      protocol: TCP
+      port: {{ .Values.applicationConfig.profiling.port }}
+---
+{{- end }}
+

deployment/event-ingester/templates/deployment.yaml

@@ -48,7 +48,7 @@ spec:
             {{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
             - containerPort: {{ .Values.applicationConfig.profiling.port }}
               protocol: TCP
-              name: pprof
+              name: profiling
             {{- end }}
             - containerPort: {{ .Values.applicationConfig.metricsPort }}
               protocol: TCP

deployment/event-ingester/templates/profiling-ingress.yaml

@@ -0,0 +1,35 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.hostnames }}
+{{- $root := . -}}
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  name: {{ include "event_ingester.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  annotations:
+    certmanager.k8s.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+    cert-manager.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+  labels:
+    {{- include "event_ingester.labels.all" . | nindent 4 }}
+spec:
+  rules:
+  {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+  - host: {{ .  }}
+    http:
+      paths:
+        - path: /
+          pathType: Prefix
+          backend:
+            service:
+              name: {{ include "event_ingester.name" $root }}-profiling
+              port:
+                number: {{ $root.Values.applicationConfig.profiling.port }}
+  {{ end -}}
+  tls:
+    - hosts:
+       {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+      - {{ . -}}
+       {{ end }}
+      secretName: {{ include "event_ingester.name" $root }}-profiling-service-tls
+---
+{{- end }}
+

deployment/event-ingester/templates/profiling-service.yaml

@@ -0,0 +1,19 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ include "event_ingester.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  labels:
+    {{- include "event_ingester.labels.all" . | nindent 4 }}
+    name: {{ include "event_ingester.name" . }}-profiling
+spec:
+  selector:
+    app: {{ include "event_ingester.name" . }}
+  ports:
+    - name: profiling
+      protocol: TCP
+      port: {{ .Values.applicationConfig.profiling.port }}
+---
+{{- end }}
+

deployment/executor/templates/deployment.yaml

@@ -55,7 +55,7 @@ spec:
             {{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
             - containerPort: {{ .Values.applicationConfig.profiling.port }}
               protocol: TCP
-              name: pprof
+              name: profiling
             {{- end }}
           volumeMounts:
             - name: user-config

deployment/executor/templates/profiling-ingress.yaml

@@ -0,0 +1,35 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.hostnames }}
+{{- $root := . -}}
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  name: {{ include "executor.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  annotations:
+    certmanager.k8s.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+    cert-manager.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+  labels:
+    {{- include "executor.labels.all" . | nindent 4 }}
+spec:
+  rules:
+  {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+  - host: {{ .  }}
+    http:
+      paths:
+        - path: /
+          pathType: Prefix
+          backend:
+            service:
+              name: {{ include "executor.name" $root }}-profiling
+              port:
+                number: {{ $root.Values.applicationConfig.profiling.port }}
+  {{ end -}}
+  tls:
+    - hosts:
+       {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+      - {{ . -}}
+       {{ end }}
+      secretName: {{ include "executor.name" $root }}-profiling-service-tls
+---
+{{- end }}
+

deployment/executor/templates/profiling-service.yaml

@@ -0,0 +1,19 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ include "executor.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  labels:
+    {{- include "executor.labels.all" . | nindent 4 }}
+    name: {{ include "executor.name" . }}-profiling
+spec:
+  selector:
+    app: {{ include "executor.name" . }}
+  ports:
+    - name: profiling
+      protocol: TCP
+      port: {{ .Values.applicationConfig.profiling.port }}
+---
+{{- end }}
+

deployment/lookout-ingester-v2/templates/deployment.yaml

@@ -48,7 +48,7 @@ spec:
             {{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
             - containerPort: {{ .Values.applicationConfig.profiling.port }}
               protocol: TCP
-              name: pprof
+              name: profiling
             {{- end }}
             - containerPort: {{ .Values.applicationConfig.metricsPort }}
               protocol: TCP

deployment/lookout-ingester-v2/templates/profiling-ingress.yaml

@@ -0,0 +1,35 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.hostnames }}
+{{- $root := . -}}
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  name: {{ include "lookout_ingester_v2.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  annotations:
+    certmanager.k8s.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+    cert-manager.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+  labels:
+    {{- include "lookout_ingester_v2.labels.all" . | nindent 4 }}
+spec:
+  rules:
+  {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+  - host: {{ .  }}
+    http:
+      paths:
+        - path: /
+          pathType: Prefix
+          backend:
+            service:
+              name: {{ include "lookout_ingester_v2.name" $root }}-profiling
+              port:
+                number: {{ $root.Values.applicationConfig.profiling.port }}
+  {{ end -}}
+  tls:
+    - hosts:
+       {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+      - {{ . -}}
+       {{ end }}
+      secretName: {{ include "lookout_ingester_v2.name" $root }}-profiling-service-tls
+---
+{{- end }}
+

deployment/lookout-ingester-v2/templates/profiling-service.yaml

@@ -0,0 +1,19 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ include "lookout_ingester_v2.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  labels:
+    {{- include "lookout_ingester_v2.labels.all" . | nindent 4 }}
+    name: {{ include "lookout_ingester_v2.name" . }}-profiling
+spec:
+  selector:
+    app: {{ include "lookout_ingester_v2.name" . }}
+  ports:
+    - name: profiling
+      protocol: TCP
+      port: {{ .Values.applicationConfig.profiling.port }}
+---
+{{- end }}
+

deployment/lookout-v2/templates/deployment.yaml

@@ -51,7 +51,7 @@ spec:
             {{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
             - containerPort: {{ .Values.applicationConfig.profiling.port }}
               protocol: TCP
-              name: pprof
+              name: profiling
             {{- end }}
             - containerPort: {{ .Values.applicationConfig.metricsPort }}
               protocol: TCP

deployment/lookout-v2/templates/profiling-ingress.yaml

@@ -0,0 +1,35 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.hostnames }}
+{{- $root := . -}}
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+  name: {{ include "lookout_v2.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  annotations:
+    certmanager.k8s.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+    cert-manager.io/cluster-issuer: {{ required "A value is required for .Values.applicationConfig.profiling.clusterIssuer" .Values.applicationConfig.profiling.clusterIssuer }}
+  labels:
+    {{- include "lookout_v2.labels.all" . | nindent 4 }}
+spec:
+  rules:
+  {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+  - host: {{ .  }}
+    http:
+      paths:
+        - path: /
+          pathType: Prefix
+          backend:
+            service:
+              name: {{ include "lookout_v2.name" $root }}-profiling
+              port:
+                number: {{ $root.Values.applicationConfig.profiling.port }}
+  {{ end -}}
+  tls:
+    - hosts:
+       {{- range required "A value is required for .Values.applicationConfig.profiling.hostnames" .Values.applicationConfig.profiling.hostnames }}
+      - {{ . -}}
+       {{ end }}
+      secretName: {{ include "lookout_v2.name" $root }}-profiling-service-tls
+---
+{{- end }}
+

deployment/lookout-v2/templates/profiling-service.yaml

@@ -0,0 +1,19 @@
+{{- if and .Values.applicationConfig.profiling .Values.applicationConfig.profiling.port }}
+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ include "lookout_v2.name" . }}-profiling
+  namespace: {{ .Release.Namespace }}
+  labels:
+    {{- include "lookout_v2.labels.all" . | nindent 4 }}
+    name: {{ include "lookout_v2.name" . }}-profiling
+spec:
+  selector:
+    app: {{ include "lookout_v2.name" . }}
+  ports:
+    - name: profiling
+      protocol: TCP
+      port: {{ .Values.applicationConfig.profiling.port }}
+---
+{{- end }}
+

deployment/scheduler/templates/scheduler-ingester-profiling-service.yaml

@@ -10,7 +10,6 @@ metadata:
 spec:
   selector:
     app: {{ include "armada-scheduler.name" . }}-ingester
-    {{- include "armada-scheduler-ingester.labels.all" . | nindent 4 }}
   ports:
     - name: profiling
       protocol: TCP