Fix Issues Arising from Confusing Weighted Costs #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
d80tb7
commented
Jun 27, 2024
| @@ -1312,6 +1312,37 @@ func TestPreemptingQueueScheduler(t *testing.T) { | |||
| "D": 1, | |||
| }, | |||
| }, | |||
| "ProtectedFractionOfFairShare non equal weights": { | |||
There was a problem hiding this comment.
This unit test demonstrates the issue
Signed-off-by: Chris Martin <[email protected]>
JamesMurkin
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cost provider returned weighted costs, this caused issues iin a couple of places where an unweighted cost was expected.
I've modified the cost provider to also return unweighted costs and have renamed the existing methods soo that it's clear they are weighted.