Show Rejections in Lookout #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
d80tb7
changed the title
…ma/rejection-lookout
Signed-off-by: Chris Martin <[email protected]>
JamesMurkin
reviewed
Jun 21, 2024
| assert.Equal(t, expectedJobError, jobError) | ||
|
|
||
| // If a row is bad then we should return an error and no updates should happen | ||
| _, err = ldb.db.Exec(armadacontext.Background(), "DELETE FROM job_error") |
There was a problem hiding this comment.
Would it be worth checking that if you try to update it with a different value, it keeps the original value?
JamesMurkin
reviewed
Jun 21, 2024
internal/lookoutv2/application.go
Outdated
| ctx := armadacontext.New(params.HTTPRequest.Context(), logger) | ||
| result, err := getJobErrorRepo.GetJobErrorMessage(ctx, params.GetJobErrorRequest.JobID) | ||
| if err != nil { | ||
| return operations.NewGetJobRunDebugMessageBadRequest().WithPayload(conversions.ToSwaggerError(err.Error())) |
There was a problem hiding this comment.
Is this right? Looks like a copy paste error with the wrong operation message
…ma/rejection-lookout
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
JamesMurkin
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend changes necessary to show rejection messages in lookout. Changes here are:
REJECTEDstate to lookoutjob_errortable to the lookout dbREJECTEDif the event failure message is of typeError_JobRejected. We also store the error in thejob_errortableWe shouldn't merge this until the frontend code is ready.