chore: align differently used Rust versions #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoccesar
changed the title
augustoccesar
changed the title
augustoccesar
changed the title
Currently, new Rust releases tend to break the workflows. In an attempt to fix that, instead of relying on stable and nightly, we can instead make it explicit which versions of Rust we want to use. The proposed solution here is: - Use 1.82 for formatting, Clippy and for running cargo make binaries. - Use 1.78 as the MSRV and for running tests. - nightly-2024-10-18 for cargo-public-api (as per recommended [on docs](https://github.com/cargo-public-api/cargo-public-api)) Why 1.82.0? Just because latest - 2 (latest 1.82). But we can choose another one if we prefer.
augustoccesar
force-pushed
the
augustoccesar/align-rust-versions
branch
from
1805939 to
4a9bf2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In an attempt to fix that, instead of relying on stable and nightly, we can
instead make it explicit which versions of Rust we want to use.
The proposed solution here is:
1.82for formatting, Clippy and for running cargo make binaries.1.78as the MSRV, running tests and build.nightly-2024-10-18for cargo-public-api (as per recommended on docs)Why 1.82.0? Just because an arbitrary
latest version - 2(latest 1.82). But we can choose another oneif we prefer.
With this bump to the rustfmt, the generated files need to be update as well. But the only change is the order
of the import to Serde Serialize/Deserialize.
Hopefully this should stop workflows from randomly failing when a new version of stable/nightly comes out, like on #656
Checklist
cargo make fmt