Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding get_all() utility function on streaming paginator #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phayes
Copy link
Contributor

@phayes phayes commented Jan 11, 2025

Summary

This adds a get_all() utility function on the streaming / async paginator, bringing the async version up to same level as the blocking version in terms of ergonomics.

For example

// Blocking (already exists)
let all_customers = Customer::list(&client, &params).unwrap().paginate(params).get_all(&client).unwrap()

// Async (this PR)
let all_customers = Customer::list(&client, &params).await.unwrap().paginate(params).get_all(&client).await.unwrap()

Checklist

@phayes phayes changed the title feat: Adding get_all utility function on streaming paginator feat: Adding get_all() utility function on streaming paginator Jan 11, 2025
@phayes
Copy link
Contributor Author

phayes commented Jan 11, 2025

It looks like a bunch of tests are failing that are unrelated to the changes in this PR - not sure what to do here

@phayes
Copy link
Contributor Author

phayes commented Jan 12, 2025

Also, let me know if you want me to make a sibling PR to the next branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant